Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2725023002:
Update vscode document (Closed)
DescriptionUpdate vscode document
1. Add setting to disable indexing.
2. Add TOCss
BUG=
Review-Url: https://codereview.chromium.org/2725023002
Cr-Commit-Position: refs/heads/master@{#454267}
Committed: https://chromium.googlesource.com/chromium/src/+/ca28511013239673d34f1f41ebf1b956e9b237aa
Patch Set 1 #Patch Set 2 : Update vscode document #
Total comments: 1
Messages
Total messages: 21 (13 generated)
The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run
The CQ bit was unchecked by chaopeng@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run
The CQ bit was unchecked by chaopeng@chromium.org
chaopeng@chromium.org changed reviewers: + rouslan@chromium.org
PTAL. Also do you know how to add link to chromium.org? Thank you.
lgtm Which page do you want to update on chromium.org? I can help with that.
On 2017/03/02 14:32:41, ಠ_ಠ wrote: > lgtm > > Which page do you want to update on chromium.org? I can help with that. I want to add: - QtCreator: https://chromium.googlesource.com/chromium/src/+/master/docs/qtcreator.md - vscode: https://chromium.googlesource.com/chromium/src/+/master/docs/vscode.md to https://www.chromium.org/developers - Editors Guides Thank you.
The CQ bit was checked by chaopeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/02 15:26:57, chaopeng wrote: > On 2017/03/02 14:32:41, ಠ_ಠ wrote: > > lgtm > > > > Which page do you want to update on chromium.org? I can help with that. > > I want to add: > > - QtCreator: > https://chromium.googlesource.com/chromium/src/+/master/docs/qtcreator.md > - vscode: https://chromium.googlesource.com/chromium/src/+/master/docs/vscode.md > > to https://www.chromium.org/developers - Editors Guides > > Thank you. Try clicking "Sign in" on the bottom left of the page. That should allow to edit it.
On 2017/03/02 15:32:20, ಠ_ಠ wrote: > On 2017/03/02 15:26:57, chaopeng wrote: > > On 2017/03/02 14:32:41, ಠ_ಠ wrote: > > > lgtm > > > > > > Which page do you want to update on chromium.org? I can help with that. > > > > I want to add: > > > > - QtCreator: > > https://chromium.googlesource.com/chromium/src/+/master/docs/qtcreator.md > > - vscode: > https://chromium.googlesource.com/chromium/src/+/master/docs/vscode.md > > > > to https://www.chromium.org/developers - Editors Guides > > > > Thank you. > > Try clicking "Sign in" on the bottom left of the page. That should allow to edit > it. Thank you.
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488468425231800,
"parent_rev": "748e8177decd9de78efe7350371f88197d7a9db8", "commit_rev":
"ca28511013239673d34f1f41ebf1b956e9b237aa"}
Message was sent while issue was closed.
Description was changed from ========== Update vscode document 1. Add setting to disable indexing. 2. Add TOCss BUG= ========== to ========== Update vscode document 1. Add setting to disable indexing. 2. Add TOCss BUG= Review-Url: https://codereview.chromium.org/2725023002 Cr-Commit-Position: refs/heads/master@{#454267} Committed: https://chromium.googlesource.com/chromium/src/+/ca28511013239673d34f1f41ebf1... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ca28511013239673d34f1f41ebf1...
Message was sent while issue was closed.
thakis@chromium.org changed reviewers: + thakis@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2725023002/diff/20001/docs/vscode.md File docs/vscode.md (right): https://codereview.chromium.org/2725023002/diff/20001/docs/vscode.md#newcode46 docs/vscode.md:46: // clang-format same comment here as in https://codereview.chromium.org/2687733003/#msg11 (in other words, the previous instructions where a bit better in this regard)
Message was sent while issue was closed.
Description was changed from ========== Update vscode document 1. Add setting to disable indexing. 2. Add TOCss BUG= Review-Url: https://codereview.chromium.org/2725023002 Cr-Commit-Position: refs/heads/master@{#454267} Committed: https://chromium.googlesource.com/chromium/src/+/ca28511013239673d34f1f41ebf1... ========== to ========== Update vscode document change clang-format settings BUG= Review-Url: https://codereview.chromium.org/2725023002 Cr-Commit-Position: refs/heads/master@{#454267} Committed: https://chromium.googlesource.com/chromium/src/+/ca28511013239673d34f1f41ebf1... ==========
Message was sent while issue was closed.
Description was changed from ========== Update vscode document change clang-format settings BUG= Review-Url: https://codereview.chromium.org/2725023002 Cr-Commit-Position: refs/heads/master@{#454267} Committed: https://chromium.googlesource.com/chromium/src/+/ca28511013239673d34f1f41ebf1... ========== to ========== Update vscode document 1. Add setting to disable indexing. 2. Add TOCss BUG= Review-Url: https://codereview.chromium.org/2725023002 Cr-Commit-Position: refs/heads/master@{#454267} Committed: https://chromium.googlesource.com/chromium/src/+/ca28511013239673d34f1f41ebf1... ==========
Message was sent while issue was closed.
Patchset #3 (id:40001) has been deleted |
