Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2687733003:
Add doc for Qt Creator (Closed)
DescriptionAdd doc for Qt Creator
BUG=
Review-Url: https://codereview.chromium.org/2687733003
Cr-Commit-Position: refs/heads/master@{#449294}
Committed: https://chromium.googlesource.com/chromium/src/+/585eef9e386393184fd7ac84290750cb849d04f1
Patch Set 1 #
Total comments: 2
Patch Set 2 : Primiano's comment #
Total comments: 1
Messages
Total messages: 24 (15 generated)
chaopeng@chromium.org changed reviewers: + primiano@chromium.org
PTAL. Thank you.
thanks LGTM with some comments. https://codereview.chromium.org/2687733003/diff/1/docs/qtcreator.md File docs/qtcreator.md (right): https://codereview.chromium.org/2687733003/diff/1/docs/qtcreator.md#newcode23 docs/qtcreator.md:23: block you while parsing. I would probably mention that you can use Qt just as a debugger frontend and that does not require to create a project (I do that all the time) https://codereview.chromium.org/2687733003/diff/1/docs/qtcreator.md#newcode113 docs/qtcreator.md:113: --no-sandbox ----render-startup-dialog --single-process single-process should not be required. is actually very likely to create problems as there is no coverage for that on desktop problems. I'd remove it. Instead I think people should use --renderer-cmd-prefix. In any case a link to linux_debugging.md would be great here.
The CQ bit was checked by chaopeng@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org Link to the patchset: https://codereview.chromium.org/2687733003/#ps20001 (title: "Primiano's comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486653057528170,
"parent_rev": "c18c1ca3ce39b15464102d92a15367b0e5a89ac7", "commit_rev":
"585eef9e386393184fd7ac84290750cb849d04f1"}
Message was sent while issue was closed.
Description was changed from ========== Add doc for Qt Creator BUG= ========== to ========== Add doc for Qt Creator BUG= Review-Url: https://codereview.chromium.org/2687733003 Cr-Commit-Position: refs/heads/master@{#449294} Committed: https://chromium.googlesource.com/chromium/src/+/585eef9e386393184fd7ac842907... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/585eef9e386393184fd7ac842907...
Message was sent while issue was closed.
thakis@chromium.org changed reviewers: + thakis@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2687733003/diff/20001/docs/qtcreator.md File docs/qtcreator.md (right): https://codereview.chromium.org/2687733003/diff/20001/docs/qtcreator.md#newco... docs/qtcreator.md:33: 2. Tools - Options - Beautifier - Clang Format, select use predefined style: The following things seem important to me: 1. clang-format should use the style from src/.clang-format -- or in general --style=file. That gives you chromium style, but sometimes with some temporary tweaks. 2. qtcreator should also use the clang-format binary in depot_tools, as clang-format's behavior changes over time. From what I understand, the instructions here don't quite achieve this. It'd be cool if you could tweak them a bit.
Message was sent while issue was closed.
Description was changed from ========== Add doc for Qt Creator BUG= Review-Url: https://codereview.chromium.org/2687733003 Cr-Commit-Position: refs/heads/master@{#449294} Committed: https://chromium.googlesource.com/chromium/src/+/585eef9e386393184fd7ac842907... ========== to ========== Add doc for Qt Creator BUG= Review-Url: https://codereview.chromium.org/2687733003 Cr-Commit-Position: refs/heads/master@{#449294} Committed: https://chromium.googlesource.com/chromium/src/+/585eef9e386393184fd7ac842907... ==========
The CQ bit was checked by chaopeng@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org Link to the patchset: https://codereview.chromium.org/2687733003/#ps40001 (title: "change clang-format settings")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by chaopeng@chromium.org
Description was changed from ========== Add doc for Qt Creator BUG= Review-Url: https://codereview.chromium.org/2687733003 Cr-Commit-Position: refs/heads/master@{#449294} Committed: https://chromium.googlesource.com/chromium/src/+/585eef9e386393184fd7ac842907... ========== to ========== Change clang-format settings in docs/qtcreator.md BUG= Review-Url: https://codereview.chromium.org/2687733003 Cr-Commit-Position: refs/heads/master@{#449294} Committed: https://chromium.googlesource.com/chromium/src/+/585eef9e386393184fd7ac842907... ==========
The CQ bit was checked by chaopeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
(i think you accidentally uploaded your change to this issue that you already landed 3 weeks ago. you need to make a new issue for the new change)
The CQ bit was unchecked by chaopeng@chromium.org
Description was changed from ========== Change clang-format settings in docs/qtcreator.md BUG= Review-Url: https://codereview.chromium.org/2687733003 Cr-Commit-Position: refs/heads/master@{#449294} Committed: https://chromium.googlesource.com/chromium/src/+/585eef9e386393184fd7ac842907... ========== to ========== Add doc for Qt Creator BUG= Review-Url: https://codereview.chromium.org/2687733003 Cr-Commit-Position: refs/heads/master@{#449294} Committed: https://chromium.googlesource.com/chromium/src/+/585eef9e386393184fd7ac842907... ==========
Message was sent while issue was closed.
On 2017/03/03 16:27:15, Nico wrote: > (i think you accidentally uploaded your change to this issue that you already > landed 3 weeks ago. you need to make a new issue for the new change) Yes, I make a mistake.
Message was sent while issue was closed.
Patchset #3 (id:40001) has been deleted |
