Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2724983006: Media Controls: do not use events but C++ callbacks for insertion/removal from document. (Closed)

Created:
3 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 9 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, Primiano Tucci (use gerrit), nessy, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Controls: do not use events but C++ callbacks for insertion/removal from document. For some reasons, the overhead of the events create some oilpan allocated free memory. It's not a memory leak but it increases the visible memory usage of Chrome for some perf bots. Using C++ callbacks resolve the issue and should be fairly similar as far as the functionality goes. BUG=697980 Review-Url: https://codereview.chromium.org/2724983006 Cr-Commit-Position: refs/heads/master@{#454772} Committed: https://chromium.googlesource.com/chromium/src/+/8e679697d635baa92d4927b2b4e838f125266af1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -38 lines) Patch
M third_party/WebKit/Source/core/html/shadow/MediaControls.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.cpp View 2 chunks +29 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp View 3 chunks +4 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegate.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mlamouri (slow - plz ping)
PTAL. Can you commit if it lgty :)
3 years, 9 months ago (2017-03-03 17:24:44 UTC) #3
mlamouri (slow - plz ping)
+primiano@ FYI
3 years, 9 months ago (2017-03-03 17:33:02 UTC) #5
Zhiqiang Zhang (Slow)
lgtm
3 years, 9 months ago (2017-03-04 13:49:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724983006/1
3 years, 9 months ago (2017-03-04 13:49:15 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-04 13:58:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8e679697d635baa92d4927b2b4e8...

Powered by Google App Engine
This is Rietveld 408576698