Media Controls: do not use events but C++ callbacks for insertion/removal from document.

third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 320 matching lines @@
       *this, MediaControlDownloadButtonElement::create(*this)));
   m_overflowList->appendChild(m_muteButton->createOverflowElement(
       *this, MediaControlMuteButtonElement::create(*this)));
   m_overflowList->appendChild(m_castButton->createOverflowElement(
       *this, MediaControlCastButtonElement::create(*this, false)));
   m_overflowList->appendChild(
       m_toggleClosedCaptionsButton->createOverflowElement(
           *this, MediaControlToggleClosedCaptionsButtonElement::create(*this)));
 }
 
+Node::InsertionNotificationRequest MediaControls::insertedInto(
+    ContainerNode* root) {
+  if (!mediaElement().isConnected())
+    return HTMLDivElement::insertedInto(root);
+
+  // TODO(mlamouri): we should show the controls instead of having
+  // HTMLMediaElement do it.
+
+  // m_windowEventListener doesn't need to be re-attached as it's only needed
+  // when a menu is visible.
+  m_mediaEventListener->attach();
+  if (m_orientationLockDelegate)
+    m_orientationLockDelegate->attach();
+
+  return HTMLDivElement::insertedInto(root);
+}
+
+void MediaControls::removedFrom(ContainerNode*) {
+  DCHECK(!mediaElement().isConnected());
+
+  // TODO(mlamouri): we hide show the controls instead of having
+  // HTMLMediaElement do it.
+
+  m_windowEventListener->stop();
+  m_mediaEventListener->detach();
+  if (m_orientationLockDelegate)
+    m_orientationLockDelegate->detach();
+}
+
 void MediaControls::reset() {
   EventDispatchForbiddenScope::AllowUserAgentEvents allowEventsInShadow;
   BatchedControlUpdate batch(this);
 
   const double duration = mediaElement().duration();
   m_durationDisplay->setTextContent(
       LayoutTheme::theme().formatMediaControlsTime(duration));
   m_durationDisplay->setCurrentValue(duration);
 
   // Show everything that we might hide.
@@ skipping 330 matching lines @@
 
 bool MediaControls::containsRelatedTarget(Event* event) {
   if (!event->isMouseEvent())
     return false;
   EventTarget* relatedTarget = toMouseEvent(event)->relatedTarget();
   if (!relatedTarget)
     return false;
   return contains(relatedTarget->toNode());
 }
 
-void MediaControls::onInsertedIntoDocument() {
-  // TODO(mlamouri): we should show the controls instead of having
-  // HTMLMediaElement do it.
-
-  // m_windowEventListener doesn't need to be re-attached as it's only needed
-  // when a menu is visible.
-  m_mediaEventListener->attach();
-  if (m_orientationLockDelegate)
-    m_orientationLockDelegate->attach();
-}
-
-void MediaControls::onRemovedFromDocument() {
-  // TODO(mlamouri): we hide show the controls instead of having
-  // HTMLMediaElement do it.
-
-  m_windowEventListener->stop();
-  m_mediaEventListener->detach();
-  if (m_orientationLockDelegate)
-    m_orientationLockDelegate->detach();
-}
-
 void MediaControls::onVolumeChange() {
   m_muteButton->updateDisplayType();
   m_volumeSlider->setVolume(mediaElement().muted() ? 0
                                                    : mediaElement().volume());
 
   // Update visibility of volume controls.
   // TODO(mlamouri): it should not be part of the volumechange handling because
   // it is using audio availability as input.
   BatchedControlUpdate batch(this);
   m_volumeSlider->setIsWanted(mediaElement().hasAudio() &&
@@ skipping 275 matching lines @@
   visitor->trace(m_overflowList);
   visitor->trace(m_castButton);
   visitor->trace(m_overlayCastButton);
   visitor->trace(m_mediaEventListener);
   visitor->trace(m_windowEventListener);
   visitor->trace(m_orientationLockDelegate);
   HTMLDivElement::trace(visitor);
 }
 
 }  // namespace blink