Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1760)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 2724673002: [WIP] Introduce ScriptResourceData
Patch Set: Fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
index 750109c2a29ec94086407080de251f984261310a..8b3f005dec5e15c9eb246bd5479a328031ae472a 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
@@ -37,7 +37,7 @@
#include "core/frame/LocalFrame.h"
#include "core/inspector/InspectorTraceEvents.h"
#include "core/inspector/ThreadDebugger.h"
-#include "core/loader/resource/ScriptResource.h"
+#include "core/loader/resource/ScriptResourceData.h"
#include "core/probe/CoreProbes.h"
#include "platform/Histogram.h"
#include "platform/ScriptForbiddenScope.h"
@@ -402,9 +402,10 @@ static std::unique_ptr<CompileFn> SelectCompileFunction(
}
// Select a compile function for a streaming compile.
-std::unique_ptr<CompileFn> SelectCompileFunction(V8CacheOptions cache_options,
- ScriptResource* resource,
- ScriptStreamer* streamer) {
+std::unique_ptr<CompileFn> SelectCompileFunction(
+ V8CacheOptions cache_options,
+ const ScriptResourceData* resource,
kinuko 2017/05/18 05:43:30 resource_data ?
+ ScriptStreamer* streamer) {
// We don't stream scripts which don't have a Resource.
DCHECK(resource);
// Failed resources should never get this far.
@@ -458,7 +459,7 @@ v8::MaybeLocal<v8::Script> V8ScriptRunner::CompileScript(
const String& source_map_url,
const TextPosition& script_start_position,
v8::Isolate* isolate,
- ScriptResource* resource,
+ const ScriptResourceData* resource,
kinuko 2017/05/18 05:43:30 ditto
ScriptStreamer* streamer,
CachedMetadataHandler* cache_handler,
AccessControlStatus access_control_status,

Powered by Google App Engine
This is Rietveld 408576698