Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp

Issue 2724673002: [WIP] Introduce ScriptResourceData
Patch Set: Fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
index 13eabaf2909320b518be139648d7ab0c53672e57..e8e7ccab784d5210b356dee10ac85545c65b4eb3 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
@@ -67,19 +67,28 @@ class V8ScriptRunnerTest : public ::testing::Test {
void SetEmptyResource() {
resource_request_ = ResourceRequest();
- resource_ = ScriptResource::Create(resource_request_, "UTF-8");
+ SetResourceInternal();
}
void SetResource() {
resource_request_ = ResourceRequest(Url());
- resource_ = ScriptResource::Create(resource_request_, "UTF-8");
+ SetResourceInternal();
+ }
+
+ void SetResourceInternal() {
+ ScriptResource* resource =
+ ScriptResource::Create(resource_request_, "UTF-8");
+ // This is not a complete Resource (e.g. lacks ResourceResponse)
+ // but is sufficient for testing here.
+ resource->Finish();
+ resource_ = resource->ResourceData();
}
CachedMetadataHandler* CacheHandler() { return resource_->CacheHandler(); }
protected:
ResourceRequest resource_request_;
- Persistent<ScriptResource> resource_;
+ Persistent<const ScriptResourceData> resource_;
static int counter_;
};

Powered by Google App Engine
This is Rietveld 408576698