Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h

Issue 2724673002: [WIP] Introduce ScriptResourceData
Patch Set: Fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h b/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h
index 52c329bd67aee1d49ef2857f100f9db8eba95a51..023b7c29da8731ca28fe31b96214ce680d00bebb 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h
@@ -33,7 +33,7 @@
#include "bindings/core/v8/ScriptStreamer.h"
#include "core/CoreExport.h"
-#include "core/loader/resource/ScriptResource.h"
+#include "core/loader/resource/ScriptResourceData.h"
#include "platform/heap/Handle.h"
#include "platform/weborigin/KURL.h"
#include "platform/wtf/text/TextPosition.h"
@@ -48,12 +48,12 @@ class CORE_EXPORT ScriptSourceCode final {
ScriptSourceCode();
// We lose the encoding information from ScriptResource.
// Not sure if that matters.
- explicit ScriptSourceCode(ScriptResource*);
+ explicit ScriptSourceCode(const ScriptResourceData*);
ScriptSourceCode(
const String&,
const KURL& = KURL(),
const TextPosition& start_position = TextPosition::MinimumPosition());
- ScriptSourceCode(ScriptStreamer*, ScriptResource*);
+ ScriptSourceCode(ScriptStreamer*, const ScriptResourceData*);
~ScriptSourceCode();
DECLARE_TRACE();
@@ -65,7 +65,7 @@ class CORE_EXPORT ScriptSourceCode final {
bool IsNull() const { return source_.IsNull(); }
const String& Source() const { return source_; }
- ScriptResource* GetResource() const { return resource_; }
+ const ScriptResourceData* GetResource() const { return resource_; }
kinuko 2017/05/18 05:43:30 GetResourceData() ?
const KURL& Url() const;
int StartLine() const { return start_position_.line_.OneBasedInt(); }
const TextPosition& StartPosition() const { return start_position_; }
@@ -77,7 +77,7 @@ class CORE_EXPORT ScriptSourceCode final {
void TreatNullSourceAsEmpty();
String source_;
- Member<ScriptResource> resource_;
+ Member<const ScriptResourceData> resource_;
Member<ScriptStreamer> streamer_;
mutable KURL url_;
TextPosition start_position_;

Powered by Google App Engine
This is Rietveld 408576698