MacViews: Enable AppleScript support.

MacViews: Enable AppleScript support.

AppleScript support is not depended on UI implementation. And for enable
it, add related files into compilation and convert related tests based
on CocoaProfileTest into "Browser Tests". As result the
BrowserCrApplication interface will be extended to support AppleScript
(see  cocoa/applescript/browsercrapplication+applescript.h(mm) files)

For test this - run next script in "Script Editor" on Mac:

tell application "Chromium"
get windows
end tell

Without this patch we receive the error.

With it, the script works fine.

BUG=697229
Review-Url: https://codereview.chromium.org/2724603002
Cr-Commit-Position: refs/heads/master@{#455062}
Committed: https://chromium.googlesource.com/chromium/src/+/2b9b8af34eb0188a1684464d1d9ff0528c9234e5

[snake, 2017-02-28 13:56:14]

The CQ bit was checked by art-snake@yandex-team.ru to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 13:56:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[snake, 2017-02-28 14:07:57]

art-snake@yandex-team.ru changed reviewers:
+ pinkerton@chromium.org, spqchan@chromium.org

[snake, 2017-02-28 14:17:32]

Description was changed from

==========
MacViews: Enable AppleScript support.
==========

to

==========
MacViews: Enable AppleScript support.

AppleScript support is not depended on UI implementation. And for enable it,
just add related files into compilation. As result the BrowserCrApplication
interface will be extended to support AppleScript (see 
cocoa/applescript/browsercrapplication+applescript.h(mm) files)

For test this - run next script in "Script Editor" on Mac:

tell application "Chromium"
get windows
end tell

Without this patch we receive the error.

With it, the script works fine.
==========

[snake, 2017-02-28 14:43:01]

art-snake@yandex-team.ru changed reviewers:
+ tapted@chromium.org

[commit-bot: I haz the power, 2017-02-28 14:49:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 14:49:48]

Dry run: This issue passed the CQ dry run.

[pink (ping after 24hrs), 2017-02-28 15:07:10]

pinkerton@chromium.org changed reviewers:
+ ellyjones@chromium.org

[pink (ping after 24hrs), 2017-02-28 15:07:10]

+ellyjones for macviews

[Elly Fong-Jones, 2017-02-28 15:48:31]

On 2017/02/28 15:07:10, pink wrote:
> +ellyjones for macviews

This CL doesn't compile right now :) please let me know when it's ready for
review.

[snake, 2017-02-28 16:03:34]

On 2017/02/28 15:48:31, Elly Fong-Jones wrote:
> On 2017/02/28 15:07:10, pink wrote:
> > +ellyjones for macviews
> 
> This CL doesn't compile right now :) please let me know when it's ready for
> review.

hm... 
The MacViews compilation already broken by CL:
https://codereview.chromium.org/2700243002

On "mac_chromium_10.10_macviews" try bot I see errors in
location_bar_view_mac_unittest.mm file, which can not be compiled for MacViews.
And this file is not related to my CL.

Should i fix this in this CL? (disable compilation of
location_bar_view_mac_unittest.mm in MacView)

[snake, 2017-02-28 16:29:43]

On 2017/02/28 16:03:34, snake wrote:
> On 2017/02/28 15:48:31, Elly Fong-Jones wrote:
> > On 2017/02/28 15:07:10, pink wrote:
> > > +ellyjones for macviews
> > 
> > This CL doesn't compile right now :) please let me know when it's ready for
> > review.
> 
> hm... 
> The MacViews compilation already broken by CL:
> https://codereview.chromium.org/2700243002
> 
> On "mac_chromium_10.10_macviews" try bot I see errors in
> location_bar_view_mac_unittest.mm file, which can not be compiled for
MacViews.
> And this file is not related to my CL.
> 
> Should i fix this in this CL? (disable compilation of
> location_bar_view_mac_unittest.mm in MacView)

CL with MacViews compilation Fix: https://codereview.chromium.org/2718253004/

[tapted, 2017-02-28 23:06:51]

Description was changed from

==========
MacViews: Enable AppleScript support.

AppleScript support is not depended on UI implementation. And for enable it,
just add related files into compilation. As result the BrowserCrApplication
interface will be extended to support AppleScript (see 
cocoa/applescript/browsercrapplication+applescript.h(mm) files)

For test this - run next script in "Script Editor" on Mac:

tell application "Chromium"
get windows
end tell

Without this patch we receive the error.

With it, the script works fine.
==========

to

==========
MacViews: Enable AppleScript support.

AppleScript support is not depended on UI implementation. And for enable
it, just add related files into compilation. As result the
BrowserCrApplication interface will be extended to support AppleScript
(see  cocoa/applescript/browsercrapplication+applescript.h(mm) files)

For test this - run next script in "Script Editor" on Mac:

tell application "Chromium"
get windows
end tell

Without this patch we receive the error.

With it, the script works fine.

BUG=697229
==========

[tapted, 2017-02-28 23:08:39]

I added BUG=697229 and wrapped your CL description. This all looks good, but we
should ensure that the test in the files being moved are passing on the bots. If
you make a git branch with the compile fixes and rebase this CL off that branch,
then reupload, then you can get them both patched in for the bot run. (But also
https://codereview.chromium.org/2718253004/ can just be landed)

[snake, 2017-03-01 15:46:35]

The CQ bit was checked by art-snake@yandex-team.ru to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 15:46:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 17:18:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 17:18:30]

Dry run: This issue passed the CQ dry run.

[snake, 2017-03-01 18:37:26]

The CQ bit was checked by art-snake@yandex-team.ru to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 18:37:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 18:44:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 18:44:01]

Dry run: This issue passed the CQ dry run.

[snake, 2017-03-01 19:11:23]

the mac_chromium_10.10_macviews build is hanging in sheduled state the much of
time (((

[snake, 2017-03-01 19:20:02]

Description was changed from

==========
MacViews: Enable AppleScript support.

AppleScript support is not depended on UI implementation. And for enable
it, just add related files into compilation. As result the
BrowserCrApplication interface will be extended to support AppleScript
(see  cocoa/applescript/browsercrapplication+applescript.h(mm) files)

For test this - run next script in "Script Editor" on Mac:

tell application "Chromium"
get windows
end tell

Without this patch we receive the error.

With it, the script works fine.

BUG=697229
==========

to

==========
MacViews: Enable AppleScript support.

AppleScript support is not depended on UI implementation. And for enable
it, add related files into compilation and convert tetsts based on
CocoaProfileTest into "Browser Tests". As result the
BrowserCrApplication interface will be extended to support AppleScript
(see  cocoa/applescript/browsercrapplication+applescript.h(mm) files)

For test this - run next script in "Script Editor" on Mac:

tell application "Chromium"
get windows
end tell

Without this patch we receive the error.

With it, the script works fine.

BUG=697229
==========

[tapted, 2017-03-01 22:39:00]

On 2017/03/01 19:11:23, snake wrote:
> the mac_chromium_10.10_macviews build is hanging in sheduled state the much of
> time (((

It's not a CQ configuration, so there's only one slave -
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_10....
. We just need to take care not to overload it with unnecessary jobs

[snake, 2017-03-02 01:31:54]

Description was changed from

==========
MacViews: Enable AppleScript support.

AppleScript support is not depended on UI implementation. And for enable
it, add related files into compilation and convert tetsts based on
CocoaProfileTest into "Browser Tests". As result the
BrowserCrApplication interface will be extended to support AppleScript
(see  cocoa/applescript/browsercrapplication+applescript.h(mm) files)

For test this - run next script in "Script Editor" on Mac:

tell application "Chromium"
get windows
end tell

Without this patch we receive the error.

With it, the script works fine.

BUG=697229
==========

to

==========
MacViews: Enable AppleScript support.

AppleScript support is not depended on UI implementation. And for enable
it, add related files into compilation and convert tests based on
CocoaProfileTest into "Browser Tests". As result the
BrowserCrApplication interface will be extended to support AppleScript
(see  cocoa/applescript/browsercrapplication+applescript.h(mm) files)

For test this - run next script in "Script Editor" on Mac:

tell application "Chromium"
get windows
end tell

Without this patch we receive the error.

With it, the script works fine.

BUG=697229
==========

[snake, 2017-03-02 11:00:07]

All apple script tests passed.

[tapted, 2017-03-02 23:16:52]

On 2017/03/02 11:00:07, snake wrote:
> All apple script tests passed.

Converting to a browser_test is probably overkill :/. But also the burden of
maintaining an extra set of test harnesses is sometimes not worth it. I'm ok
with going to browser_test. But there are alternatives:

 - you just add a ScopedViewsTestHelper test_helper to BookmarkAppleScriptTest
or CocoaProfileTest (niether really fells right though)
 - you can use chrome/test/base/browser_with_test_window_test.h (which has one
already)

[tapted, 2017-03-02 23:17:17]

also make sure you summarise the changes needed to get the tests working in the
CL description

https://codereview.chromium.org/2724603002/diff/80001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_browsertest.h
(right):

https://codereview.chromium.org/2724603002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_browsertest.h:20:
@interface FakeAppDelegate : AppController {
Does anything alloc this any more? (can we just remove it?)

https://codereview.chromium.org/2724603002/diff/80001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_browsertest.mm
(right):

https://codereview.chromium.org/2724603002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_browsertest.mm:5:
#import
"chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_browsertest.h"
this .cc file doesn't have any tests, it should just be called 

chrome/browser/ui/cocoa/test/bookmark_apple_script_test.h/cc

https://codereview.chromium.org/2724603002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_browsertest.mm:60:
[NSApp setDelegate:nil];
this doesn't belong here without a corresponding call to set it to non-nil

[snake, 2017-03-06 12:45:56]

The CQ bit was checked by art-snake@yandex-team.ru to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 12:46:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[snake, 2017-03-06 12:53:35]

Also i did try to use:
1) ScopedViewsTestHelper in BookmarkAppleScriptTest. 
But i have problems with CocoaProfileTest::TearDown. (CHECK at
https://cs.chromium.org/chromium/src/ui/gfx/test/ui_cocoa_test_helper.mm?rcl=...
) And i have not found way to fix it.

2) browser_with_test_window_test.h: 
Much problems with bookmarks initializetion and unexpected NSExeptions.

https://codereview.chromium.org/2724603002/diff/80001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_browsertest.h
(right):

https://codereview.chromium.org/2724603002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_browsertest.h:20:
@interface FakeAppDelegate : AppController {
On 2017/03/02 23:17:17, tapted wrote:
> Does anything alloc this any more? (can we just remove it?)

Done.

https://codereview.chromium.org/2724603002/diff/80001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_browsertest.mm
(right):

https://codereview.chromium.org/2724603002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_browsertest.mm:5:
#import
"chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_browsertest.h"
On 2017/03/02 23:17:17, tapted wrote:
> this .cc file doesn't have any tests, it should just be called 
> 
> chrome/browser/ui/cocoa/test/bookmark_apple_script_test.h/cc

Done.

https://codereview.chromium.org/2724603002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_browsertest.mm:60:
[NSApp setDelegate:nil];
On 2017/03/02 23:17:17, tapted wrote:
> this doesn't belong here without a corresponding call to set it to non-nil

Done.

[commit-bot: I haz the power, 2017-03-06 13:42:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 13:43:00]

Dry run: This issue passed the CQ dry run.

[snake, 2017-03-06 13:59:07]

MacViews compilation is broken again((
Fix for this:
https://codereview.chromium.org/2737523002

[tapted, 2017-03-07 07:07:51]

lgtm with the following

https://codereview.chromium.org/2724603002/diff/80001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_browsertest.mm
(right):

https://codereview.chromium.org/2724603002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_browsertest.mm:5:
#import
"chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_browsertest.h"
On 2017/03/06 12:53:34, snake wrote:
> On 2017/03/02 23:17:17, tapted wrote:
> > this .cc file doesn't have any tests, it should just be called 
> > 
> > chrome/browser/ui/cocoa/test/bookmark_apple_script_test.h/cc
> 
> Done.

That's not quite what I suggested. I guess this is OK too. There's some merit to
keeping it in /applescript/.

https://codereview.chromium.org/2724603002/diff/100001/chrome/browser/ui/BUIL...
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2724603002/diff/100001/chrome/browser/ui/BUIL...
chrome/browser/ui/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All rights
reserved.
CL description: don't forget

On 2017/03/02 23:17:17, tapted wrote:
** also make sure you summarise the changes needed to get the tests working in
the
** CL description

https://codereview.chromium.org/2724603002/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_test.h
(right):

https://codereview.chromium.org/2724603002/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_test.h:12:
#import "chrome/browser/app_controller_mac.h"
remove?

https://codereview.chromium.org/2724603002/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_test.h:15:
#include "testing/platform_test.h"
remove?

[snake, 2017-03-07 12:01:50]

Description was changed from

==========
MacViews: Enable AppleScript support.

AppleScript support is not depended on UI implementation. And for enable
it, add related files into compilation and convert tests based on
CocoaProfileTest into "Browser Tests". As result the
BrowserCrApplication interface will be extended to support AppleScript
(see  cocoa/applescript/browsercrapplication+applescript.h(mm) files)

For test this - run next script in "Script Editor" on Mac:

tell application "Chromium"
get windows
end tell

Without this patch we receive the error.

With it, the script works fine.

BUG=697229
==========

to

==========
MacViews: Enable AppleScript support.

AppleScript support is not depended on UI implementation. And for enable
it, add related files into compilation and convert related tests based
on CocoaProfileTest into "Browser Tests". As result the
BrowserCrApplication interface will be extended to support AppleScript
(see  cocoa/applescript/browsercrapplication+applescript.h(mm) files)

For test this - run next script in "Script Editor" on Mac:

tell application "Chromium"
get windows
end tell

Without this patch we receive the error.

With it, the script works fine.

BUG=697229
==========

[snake, 2017-03-07 12:03:25]

https://codereview.chromium.org/2724603002/diff/100001/chrome/browser/ui/BUIL...
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2724603002/diff/100001/chrome/browser/ui/BUIL...
chrome/browser/ui/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All rights
reserved.
On 2017/03/07 07:07:50, tapted wrote:
> CL description: don't forget
> 
> On 2017/03/02 23:17:17, tapted wrote:
> ** also make sure you summarise the changes needed to get the tests working in
> the
> ** CL description
> 

Done.

https://codereview.chromium.org/2724603002/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_test.h
(right):

https://codereview.chromium.org/2724603002/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_test.h:12:
#import "chrome/browser/app_controller_mac.h"
On 2017/03/07 07:07:50, tapted wrote:
> remove?

Done.

https://codereview.chromium.org/2724603002/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_test.h:15:
#include "testing/platform_test.h"
On 2017/03/07 07:07:50, tapted wrote:
> remove?

Done.

[snake, 2017-03-07 12:03:50]

The CQ bit was checked by art-snake@yandex-team.ru

[snake, 2017-03-07 12:03:51]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2724603002/#ps120001
(title: "MacViews: Enable AppleScript support.")

[commit-bot: I haz the power, 2017-03-07 12:04:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 13:43:33]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1488888230592500,
"parent_rev": "4c17494f13d66aa009506994631a4772a27fd9d0", "commit_rev":
"2b9b8af34eb0188a1684464d1d9ff0528c9234e5"}

[commit-bot: I haz the power, 2017-03-07 13:44:12]

Description was changed from

==========
MacViews: Enable AppleScript support.

AppleScript support is not depended on UI implementation. And for enable
it, add related files into compilation and convert related tests based
on CocoaProfileTest into "Browser Tests". As result the
BrowserCrApplication interface will be extended to support AppleScript
(see  cocoa/applescript/browsercrapplication+applescript.h(mm) files)

For test this - run next script in "Script Editor" on Mac:

tell application "Chromium"
get windows
end tell

Without this patch we receive the error.

With it, the script works fine.

BUG=697229
==========

to

==========
MacViews: Enable AppleScript support.

AppleScript support is not depended on UI implementation. And for enable
it, add related files into compilation and convert related tests based
on CocoaProfileTest into "Browser Tests". As result the
BrowserCrApplication interface will be extended to support AppleScript
(see  cocoa/applescript/browsercrapplication+applescript.h(mm) files)

For test this - run next script in "Script Editor" on Mac:

tell application "Chromium"
get windows
end tell

Without this patch we receive the error.

With it, the script works fine.

BUG=697229

Review-Url: https://codereview.chromium.org/2724603002
Cr-Commit-Position: refs/heads/master@{#455062}
Committed:
https://chromium.googlesource.com/chromium/src/+/2b9b8af34eb0188a1684464d1d9f...
==========

[commit-bot: I haz the power, 2017-03-07 13:44:13]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/2b9b8af34eb0188a1684464d1d9f...