Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2737523002:
MacViews: Fix compilation. (Closed)
DescriptionMacViews: Fix auto raw pointer deduction in extension_popup.cc.
This is a compile error since r454453.
error: [chromium-style] auto variable type must not deduce to a raw
pointer type.
BUG=425229
Review-Url: https://codereview.chromium.org/2737523002
Cr-Commit-Position: refs/heads/master@{#455464}
Committed: https://chromium.googlesource.com/chromium/src/+/284939bc567f6153ad877f3a45c40ff0869c5fcb
Patch Set 1 #
Total comments: 4
Patch Set 2 : MacViews: Fix compilation. #Messages
Total messages: 22 (15 generated)
art-snake@yandex-team.ru changed reviewers: + tapted@chromium.org
The CQ bit was checked by art-snake@yandex-team.ru to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks for addressing this! I don't give you owners unfortunately, (I suggest benwells@ for extensions.) https://codereview.chromium.org/2737523002/diff/1/chrome/browser/ui/views/ext... File chrome/browser/ui/views/extensions/extension_popup.cc (right): https://codereview.chromium.org/2737523002/diff/1/chrome/browser/ui/views/ext... chrome/browser/ui/views/extensions/extension_popup.cc:1: // Copyright (c) 2012 The Chromium Authors. All rights reserved. For the CL description, I'd go for something like MacViews: Fix auto raw pointer deduction in extension_popup.cc. This is a compile error since r454453. error: [chromium-style] auto variable type must not deduce to a raw pointer type. BUG=425229 https://codereview.chromium.org/2737523002/diff/1/chrome/browser/ui/views/ext... chrome/browser/ui/views/extensions/extension_popup.cc:51: new ExtensionPopup(host, anchor_view, arrow, show_action); This doesn't follow the patterns established in https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/PMxDx7eR_YY... I think we want auto* here.
Description was changed from ========== MacViews: Fix compilation. Fix compilation error: error: [chromium-style] auto variable type must not deduce to a raw pointer type. ========== to ========== MacViews: Fix compilation. This is a compile error since r454453. error: [chromium-style] auto variable type must not deduce to a raw pointer type. BUG=425229 ==========
Description was changed from ========== MacViews: Fix compilation. This is a compile error since r454453. error: [chromium-style] auto variable type must not deduce to a raw pointer type. BUG=425229 ========== to ========== MacViews: Fix auto raw pointer deduction in extension_popup.cc. This is a compile error since r454453. error: [chromium-style] auto variable type must not deduce to a raw pointer type. BUG=425229 ==========
The CQ bit was checked by art-snake@yandex-team.ru to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
art-snake@yandex-team.ru changed reviewers: + benwells@chromium.org
https://codereview.chromium.org/2737523002/diff/1/chrome/browser/ui/views/ext... File chrome/browser/ui/views/extensions/extension_popup.cc (right): https://codereview.chromium.org/2737523002/diff/1/chrome/browser/ui/views/ext... chrome/browser/ui/views/extensions/extension_popup.cc:1: // Copyright (c) 2012 The Chromium Authors. All rights reserved. On 2017/03/06 22:05:19, tapted wrote: > For the CL description, I'd go for something like > > MacViews: Fix auto raw pointer deduction in extension_popup.cc. > > This is a compile error since r454453. > error: [chromium-style] auto variable type must not deduce to a raw > pointer type. > > BUG=425229 > Done. https://codereview.chromium.org/2737523002/diff/1/chrome/browser/ui/views/ext... chrome/browser/ui/views/extensions/extension_popup.cc:51: new ExtensionPopup(host, anchor_view, arrow, show_action); On 2017/03/06 22:05:19, tapted wrote: > This doesn't follow the patterns established in > https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/PMxDx7eR_YY... > > I think we want auto* here. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
lgtm
lgtm, and thanks!
The CQ bit was checked by art-snake@yandex-team.ru
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488982655132080,
"parent_rev": "414b2f56e2dd29bd43012763d4eaaf5a80d00277", "commit_rev":
"284939bc567f6153ad877f3a45c40ff0869c5fcb"}
Message was sent while issue was closed.
Description was changed from ========== MacViews: Fix auto raw pointer deduction in extension_popup.cc. This is a compile error since r454453. error: [chromium-style] auto variable type must not deduce to a raw pointer type. BUG=425229 ========== to ========== MacViews: Fix auto raw pointer deduction in extension_popup.cc. This is a compile error since r454453. error: [chromium-style] auto variable type must not deduce to a raw pointer type. BUG=425229 Review-Url: https://codereview.chromium.org/2737523002 Cr-Commit-Position: refs/heads/master@{#455464} Committed: https://chromium.googlesource.com/chromium/src/+/284939bc567f6153ad877f3a45c4... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/284939bc567f6153ad877f3a45c4... |
