Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2724533003: Avoid conflict between 2 enums named Mode and 2 values named None. (Closed)

Created:
3 years, 9 months ago by Daniel Bratell
Modified:
3 years, 9 months ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid conflict between 2 enums named Mode and 2 values named None. If you include (directly or indirectly) forms/TypeAhead.h or MediaFragmentURIParser.h or track/vtt/VTTRegion.h you get conflicts either with the enum value None or the enum name Mode so give the enum a less generic name. Review-Url: https://codereview.chromium.org/2724533003 Cr-Commit-Position: refs/heads/master@{#453634} Committed: https://chromium.googlesource.com/chromium/src/+/4a505b2079c744550374aaaa186a83bc2ae657fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp View 3 chunks +6 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
Daniel Bratell
Please take a look.
3 years, 9 months ago (2017-02-28 15:45:03 UTC) #2
fs
lgtm
3 years, 9 months ago (2017-02-28 15:48:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724533003/1
3 years, 9 months ago (2017-02-28 16:03:16 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 17:45:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4a505b2079c744550374aaaa186a...

Powered by Google App Engine
This is Rietveld 408576698