Chromium Code Reviews Chromium Code Reviews
Issue
2724253002:
V1 of //tools/binary_size rewrite (Closed)
DescriptionV1 of //tools/binary_size rewrite
The key insight to the rewrite is that linker map files
are more useful than nm output. The two main difference:
1. They report object paths (.o files) rather than source paths
2. They require seconds to parse rather than 10s of minutes
Helpers:
parsers.py: Parsing logic for .map files
symbols.py: Data models for Symbol and SymbolGroup
helpers.py: Dumping group for shared functions
Executables:
analyze.py: Post-processing of parsed .map files.
create_html_breakdown.py: Replaces run_binary_size_analysis.py
query.py: CLI for analyzing symbols
NOTRY=true
BUG=681694
Review-Url: https://codereview.chromium.org/2724253002
Cr-Commit-Position: refs/heads/master@{#458397}
Committed: https://chromium.googlesource.com/chromium/src/+/20ab3bfd586341cc0d3ffc174116be53de2ca2f3
Patch Set 1 #Patch Set 2 : cleaned up into parsers #Patch Set 3 : FREEZE.unindexed #Patch Set 4 : Going for it #Patch Set 5 : nm tweaks #Patch Set 6 : yo dawg #Patch Set 7 : split into files #Patch Set 8 : add better roadmap comments #Patch Set 9 : rebase #Patch Set 10 : Add repl to query.py #
Total comments: 20
Patch Set 11 : Add test for function signatures #Patch Set 12 : README tweaks, more cases for function parsing #
Total comments: 16
Patch Set 13 : Review comments #Patch Set 14 : Size report tweaks, fix --tool-prefix, fix []s dropped from names #Patch Set 15 : Put everthing after ()s in the name, not just [attrib] #
Depends on Patchset: Messages
Total messages: 15 (9 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
