Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tools/binary_size/template/D3SymbolTreeMap.js

Issue 2724253002: V1 of //tools/binary_size rewrite (Closed)
Patch Set: Put everthing after ()s in the name, not just [attrib] Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/symbols.py ('k') | tools/binary_size/template/index.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/template/D3SymbolTreeMap.js
diff --git a/tools/binary_size/template/D3SymbolTreeMap.js b/tools/binary_size/template/D3SymbolTreeMap.js
index 4bbe82f1a32624b35abdaa148f9ded73dfe08384..2c3bab6e07f6a51f6a0d6f5932fc0207b06ae6a2 100644
--- a/tools/binary_size/template/D3SymbolTreeMap.js
+++ b/tools/binary_size/template/D3SymbolTreeMap.js
@@ -71,33 +71,12 @@ D3SymbolTreeMap._byteify = function(num) {
}
D3SymbolTreeMap._NM_SYMBOL_TYPE_DESCRIPTIONS = {
- // Definitions concisely derived from the nm 'man' page
- 'A': 'Global absolute (A)',
- 'B': 'Global uninitialized data (B)',
- 'b': 'Local uninitialized data (b)',
- 'C': 'Global uninitialized common (C)',
- 'D': 'Global initialized data (D)',
- 'd': 'Local initialized data (d)',
- 'G': 'Global small initialized data (G)',
- 'g': 'Local small initialized data (g)',
- 'i': 'Indirect function (i)',
- 'N': 'Debugging (N)',
- 'p': 'Stack unwind (p)',
- 'R': 'Global read-only data (R)',
- 'r': 'Local read-only data (r)',
- 'S': 'Global small uninitialized data (S)',
- 's': 'Local small uninitialized data (s)',
- 'T': 'Global code (T)',
- 't': 'Local code (t)',
- 'U': 'Undefined (U)',
- 'u': 'Unique (u)',
- 'V': 'Global weak object (V)',
- 'v': 'Local weak object (v)',
- 'W': 'Global weak symbol (W)',
- 'w': 'Local weak symbol (w)',
- '@': 'Vtable entry (@)', // non-standard, hack.
- '-': 'STABS debugging (-)',
- '?': 'Unrecognized (?)',
+ 'b': '.bss',
+ 'd': '.data and .data.*',
+ 'r': '.rodata',
+ 't': '.text',
+ 'v': 'Vtable entry',
+ '!': 'Generated Symbols (typeinfo, thunks, etc)',
};
D3SymbolTreeMap._NM_SYMBOL_TYPES = '';
for (var symbol_type in D3SymbolTreeMap._NM_SYMBOL_TYPE_DESCRIPTIONS) {
@@ -118,20 +97,14 @@ D3SymbolTreeMap._getSymbolDescription = function(type) {
return result;
}
-// Qualitative 12-value pastel Brewer palette.
D3SymbolTreeMap._colorArray = [
- 'rgb(141,211,199)',
- 'rgb(255,255,179)',
'rgb(190,186,218)',
- 'rgb(251,128,114)',
- 'rgb(128,177,211)',
'rgb(253,180,98)',
- 'rgb(179,222,105)',
- 'rgb(252,205,229)',
- 'rgb(217,217,217)',
- 'rgb(188,128,189)',
+ 'rgb(141,211,199)',
+ 'rgb(128,177,211)',
+ 'rgb(255,237,111)',
'rgb(204,235,197)',
- 'rgb(255,237,111)'];
+]
D3SymbolTreeMap._initColorMap = function() {
var map = {};
« no previous file with comments | « tools/binary_size/symbols.py ('k') | tools/binary_size/template/index.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698