Adding haptics for more HUD uses.

Adding haptics for more HUD uses.

Covers the following cases:
- Add bookmark.
- Delete/move bookmark/folder.
- Long press in contextual search.
- Remove Most Visited item.
- Copy Chrome version from the About Chrome settings screen.
- Copy password succeeded/failed from the password details screen.
- Resettings Translate settings.

BUG=696634
TEST=Manual testing required. See
  https://bugs.chromium.org/p/chromium/issues/detail?id=696634#c2
for things to test manually.

Review-Url: https://codereview.chromium.org/2724233003
Cr-Commit-Position: refs/heads/master@{#454343}
Committed: https://chromium.googlesource.com/chromium/src/+/64e253a51c34eeb59a13559aa52961aeab60aa34

[pink (ping after 24hrs), 2017-03-02 15:36:37]

pinkerton@chromium.org changed reviewers:
+ rohitrao@chromium.org

[rohitrao (ping after 24h), 2017-03-02 18:21:15]

LGTM but we're starting to get a lot of these calls all over the place.

Are all of these features using the same mechanism to show toasts/notifications?
 Could we move the call into the toast code?

[pink (ping after 24hrs), 2017-03-02 18:38:10]

On 2017/03/02 18:21:15, rohitrao wrote:
> LGTM but we're starting to get a lot of these calls all over the place.
> 
> Are all of these features using the same mechanism to show
toasts/notifications?
>  Could we move the call into the toast code?

That was exactly what pkl asked, and I have an action item to followup with
Louis and the MD team.

[pink (ping after 24hrs), 2017-03-02 18:38:22]

The CQ bit was checked by pinkerton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 18:38:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 19:27:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 19:27:48]

Dry run: This issue passed the CQ dry run.

[pink (ping after 24hrs), 2017-03-02 19:30:45]

The CQ bit was checked by pinkerton@chromium.org

[commit-bot: I haz the power, 2017-03-02 19:31:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 19:41:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488483045654910,
"parent_rev": "09f0d64a9f882c2957469e72a05d7ad85bc35eff", "commit_rev":
"64e253a51c34eeb59a13559aa52961aeab60aa34"}

[commit-bot: I haz the power, 2017-03-02 19:42:09]

Description was changed from

==========
Adding haptics for more HUD uses.

Covers the following cases:
- Add bookmark.
- Delete/move bookmark/folder.
- Long press in contextual search.
- Remove Most Visited item.
- Copy Chrome version from the About Chrome settings screen.
- Copy password succeeded/failed from the password details screen.
- Resettings Translate settings.

BUG=696634
TEST=Manual testing required. See
  https://bugs.chromium.org/p/chromium/issues/detail?id=696634#c2
for things to test manually.
==========

to

==========
Adding haptics for more HUD uses.

Covers the following cases:
- Add bookmark.
- Delete/move bookmark/folder.
- Long press in contextual search.
- Remove Most Visited item.
- Copy Chrome version from the About Chrome settings screen.
- Copy password succeeded/failed from the password details screen.
- Resettings Translate settings.

BUG=696634
TEST=Manual testing required. See
  https://bugs.chromium.org/p/chromium/issues/detail?id=696634#c2
for things to test manually.

Review-Url: https://codereview.chromium.org/2724233003
Cr-Commit-Position: refs/heads/master@{#454343}
Committed:
https://chromium.googlesource.com/chromium/src/+/64e253a51c34eeb59a13559aa529...
==========

[commit-bot: I haz the power, 2017-03-02 19:42:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/64e253a51c34eeb59a13559aa529...

[lpromero, 2017-03-02 23:13:07]

On 2017/03/02 18:38:10, pink wrote:
> On 2017/03/02 18:21:15, rohitrao wrote:
> > LGTM but we're starting to get a lot of these calls all over the place.
> > 
> > Are all of these features using the same mechanism to show
> toasts/notifications?
> >  Could we move the call into the toast code?
> 
> That was exactly what pkl asked, and I have an action item to followup with
> Louis and the MD team.

The haptic feedback seems more tied to the activation of a control (tapping a
button or a cell) than to what the action triggered (the appearance of an HUD in
this case).
But if we think the haptic feedback is tied to the appearance of a HUD, then I
agree it should be supported by them.