ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm - Issue 2724233003: Adding haptics for more HUD uses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm

Issue 2724233003: Adding haptics for more HUD uses. (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/settings/about_chrome_collection_view_controller.mm ('k') | ios/chrome/browser/ui/settings/translate_collection_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm

diff --git a/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm b/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm

index b07bc27e43db0edea6824bcd6ffbb052fda1bfc9..2da625e3a3e43e2c77272942f0fe17e9e08af736 100644

--- a/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm

+++ b/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm

@@ -20,6 +20,7 @@

#import "ios/chrome/browser/ui/settings/cells/password_details_item.h"

#import "ios/chrome/browser/ui/settings/reauthentication_module.h"

#import "ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.h"

+#include "ios/chrome/browser/ui/uikit_ui_util.h"

#include "ios/chrome/grit/ios_strings.h"

#import "ios/third_party/material_components_ios/src/components/CollectionCells/src/MaterialCollectionCells.h"

#import "ios/third_party/material_components_ios/src/components/Palettes/src/MaterialPalettes.h"

@@ -257,6 +258,7 @@ reauthenticationModule:(id<ReauthenticationProtocol>)reauthenticationModule

if (_plainTextPasswordShown) {

UIPasteboard* generalPasteboard = [UIPasteboard generalPasteboard];

generalPasteboard.string = _password;

+ TriggerHapticFeedbackForNotification(UINotificationFeedbackTypeSuccess);

[self showCopyPasswordResultToast:

l10n_util::GetNSString(

IDS_IOS_SETTINGS_PASSWORD_WAS_COPIED_MESSAGE)];

@@ -270,10 +272,12 @@ reauthenticationModule:(id<ReauthenticationProtocol>)reauthenticationModule

if (success) {

UIPasteboard* generalPasteboard = [UIPasteboard generalPasteboard];

generalPasteboard.string = strongSelf.get()->_password;

+ TriggerHapticFeedbackForNotification(UINotificationFeedbackTypeSuccess);

[strongSelf showCopyPasswordResultToast:

l10n_util::GetNSString(

IDS_IOS_SETTINGS_PASSWORD_WAS_COPIED_MESSAGE)];

} else {

+ TriggerHapticFeedbackForNotification(UINotificationFeedbackTypeError);

[strongSelf showCopyPasswordResultToast:

l10n_util::GetNSString(

IDS_IOS_SETTINGS_PASSWORD_WAS_NOT_COPIED_MESSAGE)];