Issue 2724183003: cc: Fix vertex opacity shaders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2724183003: cc: Fix vertex opacity shaders (Closed)

Created:
3 years, 9 months ago by ccameron

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

cc: Fix vertex opacity shaders Fix a typo that indexed by quad, not vertex. Add a pixel test to prevent regressions. BUG=694986 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2724563003 Cr-Commit-Position: refs/heads/master@{#453865} (cherry picked from commit 8558df98469ef25bcd685bd9f9b0dc080ad2dc5b) Review-Url: https://codereview.chromium.org/2724183003 . Cr-Commit-Position: refs/branch-heads/2987@{#740} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/10c39d4c0e6e423f01b86ef69b5966dea4e3c682

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -3 lines)			Patch
M	cc/output/renderer_pixeltest.cc	View	4 chunks	+49 lines, -2 lines	0 comments	Download
M	cc/output/shader.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A	cc/test/data/green_alpha_vertex_opacity.png	View	Binary file		0 comments	Download

Total messages: 2 (1 generated)

ccameron

3 years, 9 months ago (2017-03-02 19:46:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
10c39d4c0e6e423f01b86ef69b5966dea4e3c682.