cc: Fix vertex opacity shaders

cc: Fix vertex opacity shaders

Fix a typo that indexed by quad, not vertex.

Add a pixel test to prevent regressions.

BUG=694986
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2724563003
Cr-Commit-Position: refs/heads/master@{#453865}
Committed: https://chromium.googlesource.com/chromium/src/+/8558df98469ef25bcd685bd9f9b0dc080ad2dc5b

[ccameron, 2017-02-28 18:13:44]

Description was changed from

==========
cc: Fix vertex opacity shaders

Fix a typo that indexed by quad, not vertex.

Add a pixel test to prevent regressions.

BUG=694986
==========

to

==========
cc: Fix vertex opacity shaders

Fix a typo that indexed by quad, not vertex.

Add a pixel test to prevent regressions.

BUG=694986
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-02-28 18:16:01]

ccameron@chromium.org changed reviewers:
+ aelias@chromium.org

[ccameron, 2017-02-28 18:16:02]

ptal -- thanks for the analysis on this.

[ccameron, 2017-02-28 18:16:16]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 18:16:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 18:50:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 18:50:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aelias_OOO_until_Jul13, 2017-02-28 20:30:04]

lgtm, thanks.  Although it seems your new test is failing on certain platforms.

[ccameron, 2017-03-01 00:37:31]

thanks. Interesting, vertex opacity was never implemented in the software
renderer. I limited the test to the GLRenderer for now.

[ccameron, 2017-03-01 00:38:17]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-03-01 00:38:17]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org
Link to the patchset: https://codereview.chromium.org/2724563003/#ps20001
(title: "Limit to GLRenderer")

[commit-bot: I haz the power, 2017-03-01 00:39:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 02:27:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 02:27:38]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2017-03-01 05:57:05]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-03-01 05:57:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 06:31:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488347825009790,
"parent_rev": "052ae58bf06d71d46567ea3c1e8952c24ec69b29", "commit_rev":
"8558df98469ef25bcd685bd9f9b0dc080ad2dc5b"}

[commit-bot: I haz the power, 2017-03-01 06:32:47]

Description was changed from

==========
cc: Fix vertex opacity shaders

Fix a typo that indexed by quad, not vertex.

Add a pixel test to prevent regressions.

BUG=694986
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Fix vertex opacity shaders

Fix a typo that indexed by quad, not vertex.

Add a pixel test to prevent regressions.

BUG=694986
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2724563003
Cr-Commit-Position: refs/heads/master@{#453865}
Committed:
https://chromium.googlesource.com/chromium/src/+/8558df98469ef25bcd685bd9f9b0...
==========

[commit-bot: I haz the power, 2017-03-01 06:32:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8558df98469ef25bcd685bd9f9b0...