Remove NavigationManager::GetPreviousItem().

Remove NavigationManager::GetPreviousItem().

The only location interested in the previous navigation item was
a callback that received the index of the item via its parameter
so use the parameter to access the navigation item and remove the
obsolete method.

Add some helper methods to CRWSessionController to avoid creating
and then destroying std::vector<> everytime the list of navigation
items was queried.

BUG=661983
Review-Url: https://codereview.chromium.org/2724073005
Cr-Commit-Position: refs/heads/master@{#454450}
Committed: https://chromium.googlesource.com/chromium/src/+/573bd7b3152aba99ff74ad02ae1aa846ad32a448

[sdefresne, 2017-03-02 23:23:03]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 23:23:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-03-02 23:24:58]

sdefresne@chromium.org changed reviewers:
+ eugenebut@chromium.org

[sdefresne, 2017-03-02 23:24:59]

Please take a look.

[commit-bot: I haz the power, 2017-03-02 23:26:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 23:26:44]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Eugene But (OOO till 7-30), 2017-03-02 23:32:48]

lgtm

https://codereview.chromium.org/2724073005/diff/1/ios/web/navigation/crw_sess...
File ios/web/navigation/crw_session_controller.mm (right):

https://codereview.chromium.org/2724073005/diff/1/ios/web/navigation/crw_sess...
ios/web/navigation/crw_session_controller.mm:224: return [self.entries count];
nit: self.entries.count 

|count| is a property

https://codereview.chromium.org/2724073005/diff/1/ios/web/navigation/crw_sess...
ios/web/navigation/crw_session_controller.mm:648: for (NSUInteger i = 0; i <
[self.entries count]; ++i) {
ditto

[sdefresne, 2017-03-02 23:52:22]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-03-02 23:52:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2724073005/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-03-02 23:52:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 00:12:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488498742955940,
"parent_rev": "b7429fd5ffdff147d471ff27fda68e87ee1d7f23", "commit_rev":
"573bd7b3152aba99ff74ad02ae1aa846ad32a448"}

[commit-bot: I haz the power, 2017-03-03 00:13:39]

Description was changed from

==========
Remove NavigationManager::GetPreviousItem().

The only location interested in the previous navigation item was
a callback that received the index of the item via its parameter
so use the parameter to access the navigation item and remove the
obsolete method.

Add some helper methods to CRWSessionController to avoid creating
and then destroying std::vector<> everytime the list of navigation
items was queried.

BUG=661983
==========

to

==========
Remove NavigationManager::GetPreviousItem().

The only location interested in the previous navigation item was
a callback that received the index of the item via its parameter
so use the parameter to access the navigation item and remove the
obsolete method.

Add some helper methods to CRWSessionController to avoid creating
and then destroying std::vector<> everytime the list of navigation
items was queried.

BUG=661983

Review-Url: https://codereview.chromium.org/2724073005
Cr-Commit-Position: refs/heads/master@{#454450}
Committed:
https://chromium.googlesource.com/chromium/src/+/573bd7b3152aba99ff74ad02ae1a...
==========

[commit-bot: I haz the power, 2017-03-03 00:13:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/573bd7b3152aba99ff74ad02ae1a...