Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: ios/chrome/browser/tabs/tab_model.mm

Issue 2724073005: Remove NavigationManager::GetPreviousItem(). (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_model.h ('k') | ios/web/navigation/crw_session_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_model.mm
diff --git a/ios/chrome/browser/tabs/tab_model.mm b/ios/chrome/browser/tabs/tab_model.mm
index 0a4a9fdf5b0dbfd915085c012970856134f9335a..799264cfe86e4be24f19804aa164ac6bb3617a51 100644
--- a/ios/chrome/browser/tabs/tab_model.mm
+++ b/ios/chrome/browser/tabs/tab_model.mm
@@ -757,15 +757,14 @@ Tab* GetOpenerForTab(id<NSFastEnumeration> tabs, Tab* tab) {
[self saveSessionImmediately:NO];
}
-- (void)navigationCommittedInTab:(Tab*)tab {
+- (void)navigationCommittedInTab:(Tab*)tab
+ previousItem:(web::NavigationItem*)previousItem {
if (self.offTheRecord)
return;
if (![tab navigationManager])
return;
// See if the navigation was within a page; if so ignore it.
- web::NavigationItem* previousItem =
- [tab navigationManagerImpl]->GetPreviousItem();
if (previousItem) {
GURL previousURL = previousItem->GetURL();
GURL currentURL = [tab navigationManager]->GetVisibleItem()->GetURL();
« no previous file with comments | « ios/chrome/browser/tabs/tab_model.h ('k') | ios/web/navigation/crw_session_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698