[Payments] Add a Pay button in the Order summary screen

[Payments] Add a Pay button in the Order summary screen

BUG=696733
TEST=existing

Review-Url: https://codereview.chromium.org/2724063002
Cr-Commit-Position: refs/heads/master@{#454008}
Committed: https://chromium.googlesource.com/chromium/src/+/6470341429052985f7e031e623f407dcf1538f09

[Mathieu, 2017-03-01 18:24:56]

Description was changed from

==========
[Payments] Add a Pay button in the Order summary screen

BUG=696733
TEST=existing
==========

to

==========
[Payments] Add a Pay button in the Order summary screen

BUG=696733
TEST=existing
==========

[Mathieu, 2017-03-01 18:24:56]

mathp@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[Mathieu, 2017-03-01 18:25:05]

Patchset #1 (id:1) has been deleted

[Mathieu, 2017-03-01 18:25:11]

Anthony PTAL?

[anthonyvd, 2017-03-01 18:36:08]

lgtm

https://codereview.chromium.org/2724063002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/order_summary_view_controller.cc (right):

https://codereview.chromium.org/2724063002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/order_summary_view_controller.cc:152:
button->set_id(static_cast<int>(DialogViewID::PAYMENT_SHEET_PAY_BUTTON));
nit: This view ID should probably be just PAY_BUTTON since it's not only used in
the Payment Sheet.

[Mathieu, 2017-03-01 19:23:02]

https://codereview.chromium.org/2724063002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/order_summary_view_controller.cc (right):

https://codereview.chromium.org/2724063002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/order_summary_view_controller.cc:152:
button->set_id(static_cast<int>(DialogViewID::PAYMENT_SHEET_PAY_BUTTON));
On 2017/03/01 18:36:08, anthonyvd wrote:
> nit: This view ID should probably be just PAY_BUTTON since it's not only used
in
> the Payment Sheet.

ah yes done

[Mathieu, 2017-03-01 19:23:05]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-03-01 19:23:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
anthonyvd@chromium.org
Link to the patchset: https://codereview.chromium.org/2724063002/#ps60001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-03-01 19:23:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 20:11:19]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488396185130370,
"parent_rev": "ae82e3ad7862628f263303d750ee7e1ac5775219", "commit_rev":
"6470341429052985f7e031e623f407dcf1538f09"}

[commit-bot: I haz the power, 2017-03-01 20:12:03]

Description was changed from

==========
[Payments] Add a Pay button in the Order summary screen

BUG=696733
TEST=existing
==========

to

==========
[Payments] Add a Pay button in the Order summary screen

BUG=696733
TEST=existing

Review-Url: https://codereview.chromium.org/2724063002
Cr-Commit-Position: refs/heads/master@{#454008}
Committed:
https://chromium.googlesource.com/chromium/src/+/6470341429052985f7e031e623f4...
==========

[commit-bot: I haz the power, 2017-03-01 20:12:06]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6470341429052985f7e031e623f4...