Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6798)

Unified Diff: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

Issue 2724063002: [Payments] Add a Pay button in the Order summary screen (Closed)
Patch Set: addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
index aaa2a61d92c4277119af947f899b5edf6280640e..d3ce2d54890d77e9169ae11c24cd0321f4cd462b 100644
--- a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
+++ b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
@@ -171,7 +171,9 @@ PaymentSheetViewController::PaymentSheetViewController(
request->AddObserver(this);
}
-PaymentSheetViewController::~PaymentSheetViewController() {}
+PaymentSheetViewController::~PaymentSheetViewController() {
+ request()->RemoveObserver(this);
+}
std::unique_ptr<views::View> PaymentSheetViewController::CreateView() {
std::unique_ptr<views::View> content_view = base::MakeUnique<views::View>();
@@ -205,7 +207,7 @@ PaymentSheetViewController::CreatePrimaryButton() {
views::MdTextButton::CreateSecondaryUiBlueButton(
this, l10n_util::GetStringUTF16(IDS_PAYMENTS_PAY_BUTTON)));
button->set_tag(static_cast<int>(PaymentRequestCommonTags::PAY_BUTTON_TAG));
- button->set_id(static_cast<int>(DialogViewID::PAYMENT_SHEET_PAY_BUTTON));
+ button->set_id(static_cast<int>(DialogViewID::PAY_BUTTON));
pay_button_ = button.get();
UpdatePayButtonState(request()->is_ready_to_pay());
return button;

Powered by Google App Engine
This is Rietveld 408576698