Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 2724003002: Remove platform/Widget.h, it is now fully renamed to platform/FrameViewBase.h (Closed)

Created:
3 years, 9 months ago by joelhockey
Modified:
3 years, 9 months ago
Reviewers:
haraken, slangley, sashab
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove platform/Widget.h, it is now fully renamed to platform/FrameViewBase.h BUG=697351 Review-Url: https://codereview.chromium.org/2724003002 Cr-Commit-Position: refs/heads/master@{#454239} Committed: https://chromium.googlesource.com/chromium/src/+/0a7e111977232fbb33ad8db8bad857bbb3c68580

Patch Set 1 #

Patch Set 2 : Remove platform/Widget.h, it is now fully renamed to platform/FrameViewBase.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -43 lines) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/platform/Widget.h View 1 chunk +0 lines, -42 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
joelhockey
Haraken, Now that the rename of the class is done, I am planning to also ...
3 years, 9 months ago (2017-03-01 10:52:15 UTC) #2
haraken
LGTM On 2017/03/01 10:52:15, joelhockey wrote: > Haraken, Now that the rename of the class ...
3 years, 9 months ago (2017-03-01 10:55:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724003002/20001
3 years, 9 months ago (2017-03-02 03:10:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/242793)
3 years, 9 months ago (2017-03-02 07:05:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724003002/20001
3 years, 9 months ago (2017-03-02 12:03:21 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 12:47:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0a7e111977232fbb33ad8db8bad8...

Powered by Google App Engine
This is Rietveld 408576698