Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2721133003: Rename platform/Widget to platform/FrameViewBase in platform. (Closed)

Created:
3 years, 9 months ago by joelhockey
Modified:
3 years, 9 months ago
Reviewers:
haraken, slangley, sashab
CC:
blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, krit, eae+blinkwatch, fmalita+watch_chromium.org, fs, gyuyoung2, jchaffraix+rendering, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename platform/Widget to platform/FrameViewBase in platform. BUG=697351 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2721133003 Cr-Commit-Position: refs/heads/master@{#454110} Committed: https://chromium.googlesource.com/chromium/src/+/45fac28e06443491e5764ef44f3136dbcd0efb54

Patch Set 1 #

Patch Set 2 : Rename platform/Widget to platform/FrameViewBase in platform. #

Patch Set 3 : Rename platform/Widget to platform/FrameViewBase in platform. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -54 lines) Patch
M third_party/WebKit/Source/core/frame/FrameViewTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/FrameViewBase.h View 3 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/FrameViewBase.cpp View 7 chunks +18 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/HostWindow.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.h View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 5 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 30 (19 generated)
joelhockey
3 years, 9 months ago (2017-03-01 10:46:10 UTC) #5
haraken
LGTM
3 years, 9 months ago (2017-03-01 10:46:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721133003/1
3 years, 9 months ago (2017-03-01 12:14:03 UTC) #10
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/frame/RootFrameViewport.h: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-01 12:19:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721133003/1
3 years, 9 months ago (2017-03-01 12:20:16 UTC) #14
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/frame/RootFrameViewport.h: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-01 12:23:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721133003/20001
3 years, 9 months ago (2017-03-01 12:25:55 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_slimming_paint_v2/builds/3006)
3 years, 9 months ago (2017-03-01 12:41:03 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721133003/40001
3 years, 9 months ago (2017-03-01 22:24:33 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721133003/40001
3 years, 9 months ago (2017-03-01 22:28:12 UTC) #27
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 00:11:09 UTC) #30
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/45fac28e06443491e5764ef44f31...

Powered by Google App Engine
This is Rietveld 408576698