Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 2723973002: Make V8Binding helpers return LocalFrame/LocalDOMWindow as appropriate (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
index 8d10849955c0d85ba2c6a7ac8eabf0a3a14ebee9..1d0dcc9ba52c15c969d8f3984cb46af2aefaa951 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
@@ -644,10 +644,9 @@ v8::MaybeLocal<v8::Value> V8ScriptRunner::callFunction(
return v8::MaybeLocal<v8::Value>();
}
- DCHECK(!frame ||
- BindingSecurity::shouldAllowAccessToFrame(
- toDOMWindow(function->CreationContext())->toLocalDOMWindow(),
- frame, BindingSecurity::ErrorReportOption::DoNotReport));
+ DCHECK(!frame || BindingSecurity::shouldAllowAccessToFrame(
+ toLocalDOMWindow(function->CreationContext()), frame,
+ BindingSecurity::ErrorReportOption::DoNotReport));
CHECK(!ThreadState::current()->isWrapperTracingForbidden());
v8::MicrotasksScope microtasksScope(isolate,
v8::MicrotasksScope::kRunMicrotasks);

Powered by Google App Engine
This is Rietveld 408576698