third_party/WebKit/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp - Issue 2723973002: Make V8Binding helpers return LocalFrame/LocalDOMWindow as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp

Issue 2723973002: Make V8Binding helpers return LocalFrame/LocalDOMWindow as appropriate (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp

index 5a6a071cf05a0a30a9aaca505cc273a38dad38f4..19971381ff9475873d3486b6b0e5d37a6cb153e5 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp

@@ -65,9 +65,8 @@ AtomicString V8CustomXPathNSResolver::lookupNamespaceURI(const String& prefix) {

lookupNamespaceURIFunc = v8::Local<v8::Function>::Cast(lookupNamespaceURI);

if (lookupNamespaceURIFunc.IsEmpty() && !m_resolver->IsFunction()) {

- LocalFrame* frame =

- toLocalDOMWindow(toDOMWindow(m_scriptState->context()))->frame();

- if (frame && frame->host())

+ LocalFrame* frame = toLocalFrameIfNotDetached(m_scriptState->context());

+ if (frame)

frame->console().addMessage(ConsoleMessage::create(

JSMessageSource, ErrorMessageLevel,

"XPathNSResolver does not have a lookupNamespaceURI method."));