third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp - Issue 2723973002: Make V8Binding helpers return LocalFrame/LocalDOMWindow as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp

Issue 2723973002: Make V8Binding helpers return LocalFrame/LocalDOMWindow as appropriate (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp b/third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp

index 198b07f0769d7698112ac98e8e21f05142080d21..0e8691d0c6c675a3cfab30029efc7eb8375c5b7b 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp

@@ -47,7 +47,7 @@ EventListener* V8EventListenerHelper::getEventListener(

DCHECK(!isAttribute);

return V8EventListenerHelper::existingEventListener(value, scriptState);

}

- if (toDOMWindow(scriptState->context()))

+ if (toLocalDOMWindow(scriptState->context()))

return V8EventListenerHelper::ensureEventListener<V8EventListener>(

value, isAttribute, scriptState);

return V8EventListenerHelper::ensureEventListener<