Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2723943003: Revert of [wasm]implement simd lowering for f32x4->i32x4, i32x4 min/max and shift instructions (Closed)

Created:
3 years, 9 months ago by Michael Achenbach
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm]implement simd lowering for f32x4->i32x4, i32x4 min/max and shift instructions (patchset #2 id:20001 of https://codereview.chromium.org/2718323003/ ) Reason for revert: breaks nosse4: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/13871 Original issue's description: > [wasm]implement simd lowering for f32x4->i32x4, i32x4 min/max and shift instructions > > BUG=v8:4124 > R=bradnelson@chromium.org,bbudge@chromium.org,gdeepti@chromium.org,mtrofin@chromium.org,titzer@chromium.org > > Review-Url: https://codereview.chromium.org/2718323003 > Cr-Commit-Position: refs/heads/master@{#43510} > Committed: https://chromium.googlesource.com/v8/v8/+/f75748cf4ca696fff268787068419604815f8090 TBR=bbudge@chromium.org,bradnelson@chromium.org,gdeepti@chromium.org,mtrofin@chromium.org,titzer@chromium.org,aseemgarg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Review-Url: https://codereview.chromium.org/2723943003 Cr-Commit-Position: refs/heads/master@{#43512} Committed: https://chromium.googlesource.com/v8/v8/+/88c240bda5b0cf48e0eb08156a192a95fcf5e44b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -143 lines) Patch
M src/compiler/simd-scalar-lowering.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/simd-scalar-lowering.cc View 5 chunks +6 lines, -126 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 6 chunks +11 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [wasm]implement simd lowering for f32x4->i32x4, i32x4 min/max and shift instructions
3 years, 9 months ago (2017-03-01 12:39:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723943003/1
3 years, 9 months ago (2017-03-01 12:39:44 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 12:39:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/88c240bda5b0cf48e0eb08156a192a95fcf...

Powered by Google App Engine
This is Rietveld 408576698