Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2723583002: Revert of Check whether ScriptResource is still loading due to revalidation (patchset #2 id:20001 o… (Closed)

Created:
3 years, 9 months ago by hiroshige
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3025
Project:
chromium
Visibility:
Public.

Description

Revert of Check whether ScriptResource is still loading due to revalidation (patchset #2 id:20001 of https://codereview.chromium.org/2706303002/ ) Reason for revert: Sufficient data are collected and thus finishing the investigation. BUG=696305 Original issue's description: > Check whether ScriptResource is still loading due to revalidation > > ScriptResource is assumed to be already loaded when it is used by > ScriptResource::script() and PendingScript. > However, there might slight chances that isLoaded() is false due to > revalidation, possibly causing Issue 692856. > > In order to check whether and how often revalidation can cause > isLoaded() to be false in existing DCHECK()s, this CL replaces > DCHECK(isLoaded()) with three CHECK()s, each of which fails when: > 1. isLoaded() is false not because of revalidation, > 2. isLoaded() is false because revalidation is ongoing and response is > already received, and > 3. isLoaded() is false because revalidation is ongoing and response is > not yet received. > > BUG=692856 > > Review-Url: https://codereview.chromium.org/2706303002 > Cr-Commit-Position: refs/heads/master@{#453057} > Committed: https://chromium.googlesource.com/chromium/src/+/6dc58b5746363ddbb99addb4c06c69a385212b7d TBR=japhet@chromium.org,kouhei@chromium.org BUG=692856 Review-Url: https://codereview.chromium.org/2714403002 Cr-Commit-Position: refs/heads/master@{#453150} (cherry picked from commit 4c7dd9f84d0f9b306bea368e4015fae01fcd6541) Review-Url: https://codereview.chromium.org/2723583002 . Cr-Commit-Position: refs/branch-heads/3025@{#4} Cr-Branched-From: 636f441be350ec76e73b4e4f407bf8a7e86984fd-refs/heads/master@{#453134} Committed: https://chromium.googlesource.com/chromium/src/+/7f6cd2d8dede99b5d71072e115195de55ae2cacb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -24 lines) Patch
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 chunk +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/ScriptResource.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/Resource.h View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/Resource.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
hiroshige
Committed patchset #1 (id:1) manually as 7f6cd2d8dede99b5d71072e115195de55ae2cacb.
3 years, 9 months ago (2017-02-27 19:11:06 UTC) #2
kouhei (in TOK)
3 years, 9 months ago (2017-02-28 00:44:09 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698