Check whether ScriptResource is still loading due to revalidation

Check whether ScriptResource is still loading due to revalidation

ScriptResource is assumed to be already loaded when it is used by
ScriptResource::script() and PendingScript.
However, there might slight chances that isLoaded() is false due to
revalidation, possibly causing Issue 692856.

In order to check whether and how often revalidation can cause
isLoaded() to be false in existing DCHECK()s, this CL replaces
DCHECK(isLoaded()) with three CHECK()s, each of which fails when:
1. isLoaded() is false not because of revalidation,
2. isLoaded() is false because revalidation is ongoing and response is
   already received, and
3. isLoaded() is false because revalidation is ongoing and response is
   not yet received.

BUG=692856
Review-Url: https://codereview.chromium.org/2706303002
Cr-Commit-Position: refs/heads/master@{#453057}
Committed: https://chromium.googlesource.com/chromium/src/+/6dc58b5746363ddbb99addb4c06c69a385212b7d

[hiroshige, 2017-02-21 20:44:49]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 20:46:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-02-21 20:52:30]

Description was changed from

==========
Check whether ScriptResource is still loading due to revalidation

BUG=692856
==========

to

==========
Check whether ScriptResource is still loading due to revalidation

ScriptResource is assumed to be already loaded when it is used by
ScriptResource::script() and PendingScript.
However, there might slight chances that isLoaded() is false due to
revalidation, possibly causing Issue 692856.

In order to check whether and how often revalidation can cause
isLoaded() to be false in existing DCHECK()s, this CL replaces
DCHECK(isLoaded()) with three CHECK()s, each of which fails when:
1. isLoaded() is false not because of revalidation,
2. isLoaded() is false because revalidation is ongoing and response is
   already received, and
3. isLoaded() is false because revalidation is ongoing and response is
   not yet received.

BUG=692856
==========

[hiroshige, 2017-02-21 20:52:31]

hiroshige@chromium.org changed reviewers:
+ japhet@chromium.org, kouhei@chromium.org

[hiroshige, 2017-02-21 20:53:02]

PTAL.

[kouhei (in TOK), 2017-02-21 21:16:15]

lgtm

[commit-bot: I haz the power, 2017-02-21 22:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 22:48:56]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[hiroshige, 2017-02-21 23:33:28]

Nate, could you also take a look as a platform/loader OWNER?

[Nate Chapin, 2017-02-24 23:53:20]

lgtm

[hiroshige, 2017-02-25 00:01:44]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2017-02-25 00:02:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 00:05:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 00:05:25]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hiroshige, 2017-02-25 01:45:54]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 01:46:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-02-25 03:13:55]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2017-02-25 03:14:02]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2017-02-25 03:14:03]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org,
kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2706303002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-25 03:14:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 03:26:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487992442708460,
"parent_rev": "bb1b87fb08ec4407a2cf1cdcf6d9e400e253e578", "commit_rev":
"6dc58b5746363ddbb99addb4c06c69a385212b7d"}

[commit-bot: I haz the power, 2017-02-25 03:27:22]

Description was changed from

==========
Check whether ScriptResource is still loading due to revalidation

ScriptResource is assumed to be already loaded when it is used by
ScriptResource::script() and PendingScript.
However, there might slight chances that isLoaded() is false due to
revalidation, possibly causing Issue 692856.

In order to check whether and how often revalidation can cause
isLoaded() to be false in existing DCHECK()s, this CL replaces
DCHECK(isLoaded()) with three CHECK()s, each of which fails when:
1. isLoaded() is false not because of revalidation,
2. isLoaded() is false because revalidation is ongoing and response is
   already received, and
3. isLoaded() is false because revalidation is ongoing and response is
   not yet received.

BUG=692856
==========

to

==========
Check whether ScriptResource is still loading due to revalidation

ScriptResource is assumed to be already loaded when it is used by
ScriptResource::script() and PendingScript.
However, there might slight chances that isLoaded() is false due to
revalidation, possibly causing Issue 692856.

In order to check whether and how often revalidation can cause
isLoaded() to be false in existing DCHECK()s, this CL replaces
DCHECK(isLoaded()) with three CHECK()s, each of which fails when:
1. isLoaded() is false not because of revalidation,
2. isLoaded() is false because revalidation is ongoing and response is
   already received, and
3. isLoaded() is false because revalidation is ongoing and response is
   not yet received.

BUG=692856

Review-Url: https://codereview.chromium.org/2706303002
Cr-Commit-Position: refs/heads/master@{#453057}
Committed:
https://chromium.googlesource.com/chromium/src/+/6dc58b5746363ddbb99addb4c06c...
==========

[commit-bot: I haz the power, 2017-02-25 03:27:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6dc58b5746363ddbb99addb4c06c...

[hiroshige, 2017-02-27 03:18:26]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2714403002/ by hiroshige@chromium.org.

The reason for reverting is: Sufficient data are collected and thus finishing
the
investigation.

BUG=696305
.