Chromium Code Reviews
DescriptionRevert of Refactor unreliable hit test code to avoid owning_layers (patchset #3 id:40001 of https://codereview.chromium.org/2718833002/ )
Reason for revert:
May have caused RenderWidgetHostViewChildFrameTest.SwapCompositorFrame to fail on windows.
Original issue's description:
> Refactor unreliable hit test code to avoid owning_layers
>
> In [1] we switched the unreliable hit test code from using ScrollNode's
> owning_layer to using the ScrollTree's layer_id_to_scroll_node_index.
> This patch improves on [1] to not use layer_id_to_scroll_node_index
> either, which turned out to be owning_layer in disguise.
>
> The existing IsClosestScrollAncestor code has been refactored into a
> helper (IsInitialScrollHitTestReliable) that makes the main thread
> fallback cases more obvious (see: [2,3]). A test has been added for
> the failure case noticed by Ali Juma in [1] where a drawn scrollbar
> is the child of a scrolling layer but itself does not scroll.
>
> [1] https://codereview.chromium.org/2702143002
> [2] https://codereview.chromium.org/238803005
> [3] https://codereview.chromium.org/1878323002
>
> BUG=693740
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2718833002
> Cr-Commit-Position: refs/heads/master@{#453462}
> Committed: https://chromium.googlesource.com/chromium/src/+/47fcc62bde25cb7275e56c3b256c0d0dc75aefaa
TBR=ajuma@chromium.org,bokan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=693740
Review-Url: https://codereview.chromium.org/2723553003
Cr-Commit-Position: refs/heads/master@{#453516}
Committed: https://chromium.googlesource.com/chromium/src/+/b615d9eab4718e5a8f14ac44e6f2f5639c829a9f
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||