Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 1878323002: cc: Scroll on main when possible incorrect hit testing hits scrollbar. (Closed)

Created:
4 years, 8 months ago by sunxd
Modified:
4 years, 8 months ago
Reviewers:
Ian Vollick, ajuma, dtapuska
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Scroll on main when possible incorrect hit testing hits scrollbar. As explained in crrev.com/238803005, it is possible that the composited layers have holes, if the point hits the first layer below the viewport point and the scrollbar layer, and the scrollbar layer is not an ancestor of the former layer, we should scroll on main, as shown below: 1) Should scroll on main: +--..... +----scroll_layer +----scrollbar_layer (<-viewport point hits this) +--.... +----....composited_unscrollable_layer (<-viewport point hits this) 2) Can scroll on impl: +--.... +----scroll_layer +----scrollbar_layer (<-viewport point hits this) +----....composited_unscrollable_layer (<-viewport point hits this) BUG=601342 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/0b34eb5f70ea985690e856d6f58284835e629c75 Cr-Commit-Position: refs/heads/master@{#386880}

Patch Set 1 #

Patch Set 2 : Make sure the unit test fails without the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -11 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 1 chunk +72 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl.cc View 2 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
sunxd
The function name seems too long, I need some suggestions.
4 years, 8 months ago (2016-04-12 18:40:56 UTC) #3
Ian Vollick
On 2016/04/12 18:40:56, sunxd wrote: > The function name seems too long, I need some ...
4 years, 8 months ago (2016-04-12 18:55:28 UTC) #4
sunxd
The unit tests used to pass even without the patch, because the scrollable layer fully ...
4 years, 8 months ago (2016-04-12 20:05:40 UTC) #5
Ian Vollick
On 2016/04/12 20:05:40, sunxd wrote: > The unit tests used to pass even without the ...
4 years, 8 months ago (2016-04-12 20:41:10 UTC) #6
ajuma
lgtm too
4 years, 8 months ago (2016-04-12 21:31:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878323002/20001
4 years, 8 months ago (2016-04-13 00:18:06 UTC) #9
dtapuska
On 2016/04/12 21:31:55, ajuma wrote: > lgtm too lgtm
4 years, 8 months ago (2016-04-13 01:03:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 01:13:52 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 01:15:03 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b34eb5f70ea985690e856d6f58284835e629c75
Cr-Commit-Position: refs/heads/master@{#386880}

Powered by Google App Engine
This is Rietveld 408576698