Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4328)

Unified Diff: chrome/browser/chromeos/arc/arc_auth_service.cc

Issue 2723263003: arc: Provide more logging for network failures. (Closed)
Patch Set: update Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/arc_auth_service.cc
diff --git a/chrome/browser/chromeos/arc/arc_auth_service.cc b/chrome/browser/chromeos/arc/arc_auth_service.cc
index 628c2a34e0157afbd680a2d96ca7a4c1a00d9b8c..e25986fe7bc0279cb731da42372608224f85bd75 100644
--- a/chrome/browser/chromeos/arc/arc_auth_service.cc
+++ b/chrome/browser/chromeos/arc/arc_auth_service.cc
@@ -56,6 +56,7 @@ ProvisioningResult ConvertArcSignInFailureReasonToProvisioningResult(
MAP_PROVISIONING_RESULT(CLOUD_PROVISION_FLOW_FAILED);
MAP_PROVISIONING_RESULT(CLOUD_PROVISION_FLOW_TIMEOUT);
MAP_PROVISIONING_RESULT(CLOUD_PROVISION_FLOW_INTERNAL_ERROR);
+ MAP_PROVISIONING_RESULT(NO_NETWORK_CONNECTION);
}
#undef MAP_PROVISIONING_RESULT
@@ -198,6 +199,10 @@ void ArcAuthService::ReportMetrics(mojom::MetricsType metrics_type,
}
}
+void ArcAuthService::Dummy() {
Yusuke Sato 2017/03/01 20:57:09 same, please move this up.
khmel 2017/03/01 21:33:06 Deprecated, thanks for catching this!
+ NOTREACHED();
+}
+
void ArcAuthService::OnAccountInfoReady(mojom::AccountInfoPtr account_info) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
auto* instance = ARC_GET_INSTANCE_FOR_METHOD(arc_bridge_service()->auth(),

Powered by Google App Engine
This is Rietveld 408576698