Index: components/arc/common/auth.mojom |
diff --git a/components/arc/common/auth.mojom b/components/arc/common/auth.mojom |
index 0df2fa9c0480c40e6a6e82cf749c4a69568c2ea1..722581d3afbb58e819765d9489a7b1d3c18a5cba 100644 |
--- a/components/arc/common/auth.mojom |
+++ b/components/arc/common/auth.mojom |
@@ -2,7 +2,7 @@ |
// Use of this source code is governed by a BSD-style license that can be |
// found in the LICENSE file. |
-// Next MinVersion: 8 |
+// Next MinVersion: 9 |
module arc.mojom; |
@@ -12,7 +12,7 @@ enum ArcSignInFailureReason { |
// Negative values are reserved for internal use. |
// The values are shuffled to keep the backward compatibility and don't match |
// ProvisioningResult in arc_optin_uma.h |
- // Next value: 15. |
+ // Next value: 16. |
UNKNOWN_ERROR = 0, |
// Mojo errors: |
@@ -61,6 +61,9 @@ enum ArcSignInFailureReason { |
CLOUD_PROVISION_FLOW_FAILED = 5, |
CLOUD_PROVISION_FLOW_TIMEOUT = 13, |
CLOUD_PROVISION_FLOW_INTERNAL_ERROR = 14, |
+ |
+ // Network connection is unavailable. |
+ [MinVersion=8] NO_NETWORK_CONNECTION = 15, |
khmel
2017/03/01 20:39:09
[MinVersion=8] in enum is not sufficient to uprev
Yusuke Sato
2017/03/01 20:57:10
What happens if you send NO_NETWORK_CONNECTION to
Luis Héctor Chávez
2017/03/01 21:00:06
I'm also slightly against adding the dummy functio
khmel
2017/03/01 21:33:06
Personally I also consider this as minor part but
|
}; |
// These values describe the type of the Chrome account to provision. |
@@ -115,7 +118,7 @@ struct AccountInfo { |
bool is_managed@2; |
}; |
-// Next Method ID: 9. |
+// Next Method ID: 10. |
interface AuthHost { |
// Notifies Chrome that the sign-in is completed successfully. |
[MinVersion=2] OnSignInComplete@2(); |
@@ -129,6 +132,10 @@ interface AuthHost { |
// Reports metrics to Chrome to be recorded in UMA. |
[MinVersion=7] ReportMetrics@8(MetricsType metrics_type, int32 value); |
+ // Dummy method to force update mojom version. [MinVersion=8] in enum |
+ // ArcSignInFailureReasonhas has no effect. |
+ [MinVersion=8] Dummy@9(); |
Yusuke Sato
2017/03/01 20:57:10
Please move this to line 123 to lexicographically
khmel
2017/03/01 21:33:06
Good point, however deprecated :)
|
+ |
// Deprecated methods: |
// Returns an authorization code, which can be used to sign in. |