arc: Provide more logging for network failures.

chrome/browser/chromeos/arc/arc_auth_service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/arc_auth_service.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/memory/ptr_util.h"
@@ skipping 38 matching lines @@
     MAP_PROVISIONING_RESULT(DEVICE_CHECK_IN_INTERNAL_ERROR);
     MAP_PROVISIONING_RESULT(GMS_NETWORK_ERROR);
     MAP_PROVISIONING_RESULT(GMS_SERVICE_UNAVAILABLE);
     MAP_PROVISIONING_RESULT(GMS_BAD_AUTHENTICATION);
     MAP_PROVISIONING_RESULT(GMS_SIGN_IN_FAILED);
     MAP_PROVISIONING_RESULT(GMS_SIGN_IN_TIMEOUT);
     MAP_PROVISIONING_RESULT(GMS_SIGN_IN_INTERNAL_ERROR);
     MAP_PROVISIONING_RESULT(CLOUD_PROVISION_FLOW_FAILED);
     MAP_PROVISIONING_RESULT(CLOUD_PROVISION_FLOW_TIMEOUT);
     MAP_PROVISIONING_RESULT(CLOUD_PROVISION_FLOW_INTERNAL_ERROR);
+    MAP_PROVISIONING_RESULT(NO_NETWORK_CONNECTION);
   }
 #undef MAP_PROVISIONING_RESULT
 
   NOTREACHED() << "unknown reason: " << static_cast<int>(reason);
   return ProvisioningResult::UNKNOWN_ERROR;
 }
 
 mojom::ChromeAccountType GetAccountType() {
   return IsArcKioskMode() ? mojom::ChromeAccountType::ROBOT_ACCOUNT
                           : mojom::ChromeAccountType::USER_ACCOUNT;
@@ skipping 122 matching lines @@
       UpdateAuthTiming("ArcAuth.CheckinTime",
                        base::TimeDelta::FromMilliseconds(value));
       break;
     case mojom::MetricsType::SIGNIN_TIME_MILLISECONDS:
       UpdateAuthTiming("ArcAuth.SignInTime",
                        base::TimeDelta::FromMilliseconds(value));
       break;
   }
 }
 
+void ArcAuthService::Dummy() {

[Yusuke Sato, 2017/03/01 20:57:09]

same, please move this up.

[khmel, 2017/03/01 21:33:06]

Deprecated, thanks for catching this!

+  NOTREACHED();
+}
+
 void ArcAuthService::OnAccountInfoReady(mojom::AccountInfoPtr account_info) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   auto* instance = ARC_GET_INSTANCE_FOR_METHOD(arc_bridge_service()->auth(),
                                                OnAccountInfoReady);
   DCHECK(instance);
   instance->OnAccountInfoReady(std::move(account_info));
 }
 
 void ArcAuthService::GetAuthCodeDeprecated0(
     const GetAuthCodeDeprecated0Callback& callback) {
@@ skipping 103 matching lines @@
     return;
   }
 
   notifier_->Notify(
       !IsArcOptInVerificationDisabled(), auth_code, GetAccountType(),
       policy_util::IsAccountManaged(ArcSessionManager::Get()->profile()));
   notifier_.reset();
 }
 
 }  // namespace arc