Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2723263002: test.dart: Cope with errors when locating the VS toolchain on Windows. (Closed)

Created:
3 years, 9 months ago by Florian Schneider
Modified:
3 years, 9 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

test.dart: Cope with errors when locating the VS toolchain on Windows. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/b7359ace36c5cb77d3ce988714d509a829e4d087

Patch Set 1 #

Patch Set 2 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M tools/testing/dart/test_configurations.dart View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
3 years, 9 months ago (2017-03-01 20:29:43 UTC) #1
Bill Hesse
lgtm
3 years, 9 months ago (2017-03-08 10:06:34 UTC) #2
Florian Schneider
3 years, 9 months ago (2017-03-09 20:35:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b7359ace36c5cb77d3ce988714d509a829e4d087 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698