Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: tools/testing/dart/test_configurations.dart

Issue 2723263002: test.dart: Cope with errors when locating the VS toolchain on Windows. (Closed)
Patch Set: formatting Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test_configurations; 5 library test_configurations;
6 6
7 import "dart:async"; 7 import "dart:async";
8 import 'dart:convert'; 8 import 'dart:convert';
9 import 'dart:io'; 9 import 'dart:io';
10 import "dart:math" as math; 10 import "dart:math" as math;
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 } 294 }
295 295
296 // Start all the HTTP servers required before starting the process queue. 296 // Start all the HTTP servers required before starting the process queue.
297 if (!serverFutures.isEmpty) { 297 if (!serverFutures.isEmpty) {
298 await Future.wait(serverFutures); 298 await Future.wait(serverFutures);
299 } 299 }
300 300
301 if (Platform.isWindows) { 301 if (Platform.isWindows) {
302 // When running tests on Windows, use cdb from depot_tools to dump 302 // When running tests on Windows, use cdb from depot_tools to dump
303 // stack traces of tests timing out. 303 // stack traces of tests timing out.
304 var text = await new File(VS_TOOLCHAIN_FILE.toNativePath()).readAsString(); 304 try {
305 firstConf['win_sdk_path'] = JSON.decode(text)['win_sdk']; 305 var text =
306 await new File(VS_TOOLCHAIN_FILE.toNativePath()).readAsString();
307 firstConf['win_sdk_path'] = JSON.decode(text)['win_sdk'];
308 } on dynamic {
309 // Ignore errors here. If win_sdk is not found, stack trace dumping
310 // for timeouts won't work.
311 }
306 } 312 }
307 313
308 // [firstConf] is needed here, since the ProcessQueue needs to know the 314 // [firstConf] is needed here, since the ProcessQueue needs to know the
309 // settings of 'noBatch' and 'local_ip' 315 // settings of 'noBatch' and 'local_ip'
310 new ProcessQueue( 316 new ProcessQueue(
311 firstConf, 317 firstConf,
312 maxProcesses, 318 maxProcesses,
313 maxBrowserProcesses, 319 maxBrowserProcesses,
314 startTime, 320 startTime,
315 testSuites, 321 testSuites,
316 eventListener, 322 eventListener,
317 allTestsFinished, 323 allTestsFinished,
318 verbose, 324 verbose,
319 recordingPath, 325 recordingPath,
320 recordingOutputPath, 326 recordingOutputPath,
321 adbDevicePool); 327 adbDevicePool);
322 } 328 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698