Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: tools/testing/dart/test_configurations.dart

Issue 2723263002: test.dart: Cope with errors when locating the VS toolchain on Windows. (Closed)
Patch Set: formatting Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_configurations.dart
diff --git a/tools/testing/dart/test_configurations.dart b/tools/testing/dart/test_configurations.dart
index 1592b0cbb5bd56b3ea8f9663fe3021a0e8c02b0a..fa8c7e07f81acdd665dc204fe7eb3c8b2946fa78 100644
--- a/tools/testing/dart/test_configurations.dart
+++ b/tools/testing/dart/test_configurations.dart
@@ -301,8 +301,14 @@ Future testConfigurations(List<Map> configurations) async {
if (Platform.isWindows) {
// When running tests on Windows, use cdb from depot_tools to dump
// stack traces of tests timing out.
- var text = await new File(VS_TOOLCHAIN_FILE.toNativePath()).readAsString();
- firstConf['win_sdk_path'] = JSON.decode(text)['win_sdk'];
+ try {
+ var text =
+ await new File(VS_TOOLCHAIN_FILE.toNativePath()).readAsString();
+ firstConf['win_sdk_path'] = JSON.decode(text)['win_sdk'];
+ } on dynamic {
+ // Ignore errors here. If win_sdk is not found, stack trace dumping
+ // for timeouts won't work.
+ }
}
// [firstConf] is needed here, since the ProcessQueue needs to know the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698