Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2723253003: build: Enable auto raw pointer deduction check everywhere on clang. (Closed)

Created:
3 years, 9 months ago by vmpstr
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

build: Enable auto raw pointer deduction check everywhere on clang. This patch enables the raw pointer deduction check on every platform. R=danakj@chromium.org, thakis@chromium.org BUG=554600 Review-Url: https://codereview.chromium.org/2723253003 Cr-Commit-Position: refs/heads/master@{#454453} Committed: https://chromium.googlesource.com/chromium/src/+/27c78942d0fbb0f64fa9d1b8c44207f7a917912e

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Patch Set 4 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M build/config/clang/BUILD.gn View 1 chunk +4 lines, -10 lines 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/web/blocked_popup_tab_helper_unittest.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (22 generated)
vmpstr
Please take a look. I'll fix up any issues in this patch if trybots are ...
3 years, 9 months ago (2017-03-01 23:42:56 UTC) #3
Nico
lgtm
3 years, 9 months ago (2017-03-01 23:48:44 UTC) #4
danakj
:clapping_hands: LGTM :clapping_hands:
3 years, 9 months ago (2017-03-01 23:52:58 UTC) #5
vmpstr
+lpromero for ios/chrome/browser/payments. Please take a look.
3 years, 9 months ago (2017-03-02 17:15:22 UTC) #11
vmpstr
+rohitrao for ios/chrome. Please take a look.
3 years, 9 months ago (2017-03-02 23:17:21 UTC) #22
rohitrao (ping after 24h)
lgtm
3 years, 9 months ago (2017-03-02 23:27:01 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723253003/80001
3 years, 9 months ago (2017-03-02 23:29:13 UTC) #27
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 00:33:55 UTC) #30
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/27c78942d0fbb0f64fa9d1b8c442...

Powered by Google App Engine
This is Rietveld 408576698