ios/chrome/browser/tabs/tab.mm - Issue 2723253003: build: Enable auto raw pointer deduction check everywhere on clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2723253003: build: Enable auto raw pointer deduction check everywhere on clang. (Closed)

Patch Set: update Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/tabs/tab.mm

diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm

index 62341e6bafff0811f9a4a3c31adf59ca9ff84365..a52cf76e327e9522e32dd0f14fe14cb318ca6fbb 100644

--- a/ios/chrome/browser/tabs/tab.mm

+++ b/ios/chrome/browser/tabs/tab.mm

@@ -1399,7 +1399,7 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,

- (void)webState:(web::WebState*)webState

didFinishNavigation:(web::NavigationContext*)navigation {

if (navigation->IsSamePage()) {

- auto faviconDriver = favicon::WebFaviconDriver::FromWebState(webState);

+ auto* faviconDriver = favicon::WebFaviconDriver::FromWebState(webState);

if (faviconDriver) {

// Fetch the favicon for the new URL.

faviconDriver->FetchFavicon(navigation->GetUrl());