Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 2723163002: gpu: Replace more chrome ipc with mojom api. (Closed)

Created:
3 years, 9 months ago by sadrul
Modified:
3 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, piman+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Replace more chrome ipc with mojom api. List of ipc messages replaced: . GpuMsg_CloseChannel . GpuMsg_LoadedShader . GpuMsg_DestroyingVideoSurface and GpuHostMsg_DestroyingVideoSurfaceAck . GpuMsg_WakeUpGpu BUG=643746, 643746 Review-Url: https://codereview.chromium.org/2723163002 Cr-Commit-Position: refs/heads/master@{#454623} Committed: https://chromium.googlesource.com/chromium/src/+/9cef0dfbd1deadc0f89e6ec7efb13309e7cea565

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Total comments: 4

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -78 lines) Patch
M content/browser/gpu/gpu_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 7 chunks +13 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 3 chunks +11 lines, -6 lines 0 comments Download
M content/common/gpu_host_messages.h View 1 4 chunks +0 lines, -21 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 4 chunks +0 lines, -30 lines 0 comments Download
M services/ui/gpu/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/gpu/gpu_service.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M services/ui/gpu/gpu_service.cc View 1 2 3 2 chunks +37 lines, -0 lines 0 comments Download
M services/ui/gpu/interfaces/gpu_service.mojom View 1 2 chunks +13 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 31 (21 generated)
sadrul
tsepez@ for ipc changes (mojom, messages). jbauman@ for all of it. Thanks! https://codereview.chromium.org/2723163002/diff/20001/content/browser/renderer_host/render_widget_host_view_android.cc File content/browser/renderer_host/render_widget_host_view_android.cc ...
3 years, 9 months ago (2017-03-01 17:53:36 UTC) #7
Tom Sepez
messages LGTM but redbots.
3 years, 9 months ago (2017-03-01 19:48:05 UTC) #10
sadrul
On 2017/03/01 19:48:05, Tom Sepez wrote: > messages LGTM but redbots. Whoops, sorry. Fixed! (missing ...
3 years, 9 months ago (2017-03-01 20:04:17 UTC) #13
jbauman
https://codereview.chromium.org/2723163002/diff/40001/content/browser/renderer_host/render_widget_host_view_android.cc File content/browser/renderer_host/render_widget_host_view_android.cc (right): https://codereview.chromium.org/2723163002/diff/40001/content/browser/renderer_host/render_widget_host_view_android.cc#newcode1563 content/browser/renderer_host/render_widget_host_view_android.cc:1563: GpuProcessHost::CallOnIO(GpuProcessHost::GPU_PROCESS_KIND_UNSANDBOXED, Use a version that dispatches to the correct ...
3 years, 9 months ago (2017-03-01 22:44:26 UTC) #16
sadrul
https://codereview.chromium.org/2723163002/diff/40001/content/browser/renderer_host/render_widget_host_view_android.cc File content/browser/renderer_host/render_widget_host_view_android.cc (right): https://codereview.chromium.org/2723163002/diff/40001/content/browser/renderer_host/render_widget_host_view_android.cc#newcode1563 content/browser/renderer_host/render_widget_host_view_android.cc:1563: GpuProcessHost::CallOnIO(GpuProcessHost::GPU_PROCESS_KIND_UNSANDBOXED, On 2017/03/01 22:44:25, jbauman wrote: > Use a ...
3 years, 9 months ago (2017-03-02 00:34:28 UTC) #19
sadrul
+dalecurtis@ for DEPS on //media/gpu (from //services/ui/gpu)
3 years, 9 months ago (2017-03-03 03:56:30 UTC) #23
jbauman
lgtm
3 years, 9 months ago (2017-03-03 06:22:59 UTC) #24
DaleCurtis
DEPS lgtm
3 years, 9 months ago (2017-03-03 17:15:35 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723163002/50001
3 years, 9 months ago (2017-03-03 17:17:26 UTC) #28
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 18:18:51 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/9cef0dfbd1deadc0f89e6ec7efb1...

Powered by Google App Engine
This is Rietveld 408576698