[Devtools] Flaten colors for network waterfall's resource colors view

[Devtools] Flaten colors for network waterfall's resource colors view

This patch is in preporation to draw items in network timeline panel in
layers. To make it easier to draw in layers I removed the gradients we
currently have with flattened versions.

See: http://imgur.com/a/Nbis6 (note these two are from different requests)

R=caseq,luoe
BUG=697669
Review-Url: https://codereview.chromium.org/2723053003
Cr-Commit-Position: refs/heads/master@{#455703}
Committed: https://chromium.googlesource.com/chromium/src/+/2f6c9f2a9a793b4b57d3b52fc59e7545dffceb65

[allada, 2017-03-02 00:13:29]

Description was changed from

==========
[Devtools] Flaten colors for network waterfall's resource colors view

This patch is in preporation to draw items in network timeline panel in
layers. To make it easier to draw in layers I removed the gradients we
currently have with flattened versions.

R=caseq,luoe
BUG=697669
==========

to

==========
[Devtools] Flaten colors for network waterfall's resource colors view

This patch is in preporation to draw items in network timeline panel in
layers. To make it easier to draw in layers I removed the gradients we
currently have with flattened versions.

See: http://imgur.com/a/Nbis6

R=caseq,luoe
BUG=697669
==========

[allada, 2017-03-02 00:19:17]

Description was changed from

==========
[Devtools] Flaten colors for network waterfall's resource colors view

This patch is in preporation to draw items in network timeline panel in
layers. To make it easier to draw in layers I removed the gradients we
currently have with flattened versions.

See: http://imgur.com/a/Nbis6

R=caseq,luoe
BUG=697669
==========

to

==========
[Devtools] Flaten colors for network waterfall's resource colors view

This patch is in preporation to draw items in network timeline panel in
layers. To make it easier to draw in layers I removed the gradients we
currently have with flattened versions.

See: http://imgur.com/a/Nbis6 (note these two are from different requests)

R=caseq,luoe
BUG=697669
==========

[allada, 2017-03-02 00:24:14]

Patchset #1 (id:1) has been deleted

[allada, 2017-03-02 00:24:30]

PTL

https://codereview.chromium.org/2723053003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
(right):

https://codereview.chromium.org/2723053003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js:64:
* @param {string} color
I moved these above because I am going to be adding more code in this area to
setup colors in a few paths, and I thought it'd be easier to see diffs in this
place from here on out.

[luoe, 2017-03-06 17:28:02]

The changes look good, but one question: why are we removing the color caches?

[allada, 2017-03-06 18:09:33]

On 2017/03/06 17:28:02, luoe wrote:
> The changes look good, but one question: why are we removing the color caches?

It is not super obvious in this patch, but I felt this was the best place to
remove this code,
but in a future patch all colors will be calculated one time in the constructor.

[caseq, 2017-03-09 00:19:49]

Can we either keep the cache or merge this one with the patch that makes all
colors calculated just once? It kinda feels unfortunate to potentially regress
performance for no reason.

[allada, 2017-03-09 00:40:46]

On 2017/03/09 00:19:49, caseq wrote:
> Can we either keep the cache or merge this one with the patch that makes all
> colors calculated just once? It kinda feels unfortunate to potentially regress
> performance for no reason.

I can however the reason the cache was introduced was not because modifying
the color was expensive the expensive part was: context.createLinearGradient()
which was removed in this patch.

[caseq, 2017-03-09 00:52:08]

On 2017/03/09 00:40:46, allada wrote:

> I can however the reason the cache was introduced was not because modifying
> the color was expensive the expensive part was: context.createLinearGradient()
> which was removed in this patch.

Fair point, lgtm then!

[allada, 2017-03-09 01:42:10]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2017-03-09 01:42:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 02:27:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 02:27:50]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[allada, 2017-03-09 07:51:51]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2017-03-09 07:52:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 08:55:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489045911760690,
"parent_rev": "c173bd4d5a794e2f83edf3ff860e98a1199c0510", "commit_rev":
"2f6c9f2a9a793b4b57d3b52fc59e7545dffceb65"}

[commit-bot: I haz the power, 2017-03-09 08:56:00]

Description was changed from

==========
[Devtools] Flaten colors for network waterfall's resource colors view

This patch is in preporation to draw items in network timeline panel in
layers. To make it easier to draw in layers I removed the gradients we
currently have with flattened versions.

See: http://imgur.com/a/Nbis6 (note these two are from different requests)

R=caseq,luoe
BUG=697669
==========

to

==========
[Devtools] Flaten colors for network waterfall's resource colors view

This patch is in preporation to draw items in network timeline panel in
layers. To make it easier to draw in layers I removed the gradients we
currently have with flattened versions.

See: http://imgur.com/a/Nbis6 (note these two are from different requests)

R=caseq,luoe
BUG=697669

Review-Url: https://codereview.chromium.org/2723053003
Cr-Commit-Position: refs/heads/master@{#455703}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f6c9f2a9a793b4b57d3b52fc59e...
==========

[commit-bot: I haz the power, 2017-03-09 08:56:03]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2f6c9f2a9a793b4b57d3b52fc59e...