Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2723203003: [Devtools] Removed @unrestricted from NetworkWaterfallColumn (Closed)

Created:
3 years, 9 months ago by allada
Modified:
3 years, 9 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Removed @unrestricted from NetworkWaterfallColumn This patch is trival and only adds the required code to allow closure to compile without @unrestricted. R=lushnikov BUG=None Review-Url: https://codereview.chromium.org/2723203003 Cr-Commit-Position: refs/heads/master@{#455716} Committed: https://chromium.googlesource.com/chromium/src/+/a715c8f907438fbe778b2d54372108023f2ee973

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js View 3 chunks +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (11 generated)
allada
PTL
3 years, 9 months ago (2017-03-02 01:20:35 UTC) #1
lushnikov
lgtm
3 years, 9 months ago (2017-03-02 01:21:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723203003/1
3 years, 9 months ago (2017-03-09 10:11:44 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 11:23:47 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a715c8f907438fbe778b2d543721...

Powered by Google App Engine
This is Rietveld 408576698