Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2722833003: Reland of [Chromecast] Process streams with different post-processing. (Closed)

Created:
3 years, 9 months ago by bshaya
Modified:
3 years, 9 months ago
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, gfhuang+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [Chromecast] Process streams with different post-processing. (patchset #1 id:1 of https://codereview.chromium.org/2722673004/ ) Reason for revert: Fix breakage Original issue's description: > Revert of [Chromecast] Process streams with different post-processing. (patchset #14 id:260001 of https://codereview.chromium.org/2701613006/ ) > > Reason for revert: > Breaks some chromecast builds due to missing include for <string> in media_pipeline_device_params.h > > Original issue's description: > > [Chromecast] Process streams with different post-processing. > > > > Adds |name| to stream_mixer_alsa_input_impl. > > stream_mixer_alsa can then mix streams of the same time separately, > > and apply different post-processing to each. > > Also reduce buffering of system streams from 300ms to 60ms. > > > > BUG=internal b/34817384 > > TEST=manual > > > > Change-Id: Ieb91e419d7d34c374d83941c02f2546696b4f489 > > Review-Url: https://codereview.chromium.org/2701613006 > > Cr-Commit-Position: refs/heads/master@{#453522} > > Committed: https://chromium.googlesource.com/chromium/src/+/e975664dab5f430b66817238898839b333822ac3 > > TBR=kmackay@chromium.org,tianyuwang@google.com,gfhuang@chromium.org,wzhong@chromium.org,jyw@chromium.org,alokp@chromium.org,halliwell@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=internal b/34817384 > > Review-Url: https://codereview.chromium.org/2722673004 > Cr-Commit-Position: refs/heads/master@{#453613} > Committed: https://chromium.googlesource.com/chromium/src/+/65dc9e8742f0e87c511806dcc3823cc4c4be8ad4 TBR=kmackay@chromium.org,tianyuwang@google.com,gfhuang@chromium.org,wzhong@chromium.org,jyw@chromium.org,alokp@chromium.org,halliwell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=internal b/34817384 Review-Url: https://codereview.chromium.org/2722833003 Cr-Commit-Position: refs/heads/master@{#453769} Committed: https://chromium.googlesource.com/chromium/src/+/d6a8436e67d97350649ca029d212699a93af5e67

Patch Set 1 #

Patch Set 2 : Fix include error #

Patch Set 3 : Handle empty device_id as DefaultDevice #

Unified diffs Side-by-side diffs Delta from patch set Stats (+517 lines, -129 lines) Patch
M chromecast/media/base/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A chromecast/media/base/audio_device_ids.h View 1 chunk +22 lines, -0 lines 0 comments Download
A chromecast/media/base/audio_device_ids.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M chromecast/media/cma/backend/alsa/BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M chromecast/media/cma/backend/alsa/audio_filter_factory.h View 1 1 chunk +6 lines, -1 line 0 comments Download
A chromecast/media/cma/backend/alsa/filter_group.h View 1 chunk +87 lines, -0 lines 0 comments Download
A chromecast/media/cma/backend/alsa/filter_group.cc View 1 chunk +119 lines, -0 lines 0 comments Download
M chromecast/media/cma/backend/alsa/media_pipeline_backend_alsa.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chromecast/media/cma/backend/alsa/media_pipeline_backend_alsa.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa.h View 1 5 chunks +16 lines, -14 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc View 1 2 12 chunks +99 lines, -93 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input_impl.h View 1 5 chunks +9 lines, -0 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input_impl.cc View 1 7 chunks +18 lines, -5 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_unittest.cc View 1 5 chunks +55 lines, -2 lines 0 comments Download
M chromecast/media/cma/backend/media_pipeline_backend_manager.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/media/cma/pipeline/load_type.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/media/cma/pipeline/media_pipeline_impl.cc View 1 2 chunks +14 lines, -5 lines 0 comments Download
M chromecast/media/service/cast_renderer.cc View 1 3 chunks +16 lines, -1 line 0 comments Download
M chromecast/public/media/media_pipeline_device_params.h View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
bshaya
Created Reland of [Chromecast] Process streams with different post-processing.
3 years, 9 months ago (2017-02-28 16:58:11 UTC) #1
halliwell
On 2017/02/28 16:58:11, bshaya wrote: > Created Reland of [Chromecast] Process streams with different post-processing. ...
3 years, 9 months ago (2017-02-28 17:14:29 UTC) #2
bshaya
On 2017/02/28 17:14:29, halliwell wrote: > On 2017/02/28 16:58:11, bshaya wrote: > > Created Reland ...
3 years, 9 months ago (2017-02-28 17:17:44 UTC) #3
tianyuwang1
lgtm
3 years, 9 months ago (2017-02-28 20:51:23 UTC) #4
tianyuwang1
lgtm
3 years, 9 months ago (2017-02-28 20:51:25 UTC) #5
kmackay
lgtm
3 years, 9 months ago (2017-02-28 20:55:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722833003/300001
3 years, 9 months ago (2017-03-01 00:09:27 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 00:27:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:300001) as
https://chromium.googlesource.com/chromium/src/+/d6a8436e67d97350649ca029d212...

Powered by Google App Engine
This is Rietveld 408576698