Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 2722673004: Revert of [Chromecast] Process streams with different post-processing. (Closed)

Created:
3 years, 9 months ago by bshaya
Modified:
3 years, 9 months ago
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, gfhuang+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromecast] Process streams with different post-processing. (patchset #14 id:260001 of https://codereview.chromium.org/2701613006/ ) Reason for revert: Breaks some chromecast builds due to missing include for <string> in media_pipeline_device_params.h Original issue's description: > [Chromecast] Process streams with different post-processing. > > Adds |name| to stream_mixer_alsa_input_impl. > stream_mixer_alsa can then mix streams of the same time separately, > and apply different post-processing to each. > Also reduce buffering of system streams from 300ms to 60ms. > > BUG=internal b/34817384 > TEST=manual > > Change-Id: Ieb91e419d7d34c374d83941c02f2546696b4f489 > Review-Url: https://codereview.chromium.org/2701613006 > Cr-Commit-Position: refs/heads/master@{#453522} > Committed: https://chromium.googlesource.com/chromium/src/+/e975664dab5f430b66817238898839b333822ac3 TBR=kmackay@chromium.org,tianyuwang@google.com,gfhuang@chromium.org,wzhong@chromium.org,jyw@chromium.org,alokp@chromium.org,halliwell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=internal b/34817384 Review-Url: https://codereview.chromium.org/2722673004 Cr-Commit-Position: refs/heads/master@{#453613} Committed: https://chromium.googlesource.com/chromium/src/+/65dc9e8742f0e87c511806dcc3823cc4c4be8ad4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -521 lines) Patch
M chromecast/media/base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D chromecast/media/base/audio_device_ids.h View 1 chunk +0 lines, -22 lines 0 comments Download
D chromecast/media/base/audio_device_ids.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M chromecast/media/cma/backend/alsa/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chromecast/media/cma/backend/alsa/audio_filter_factory.h View 1 chunk +1 line, -6 lines 0 comments Download
D chromecast/media/cma/backend/alsa/filter_group.h View 1 chunk +0 lines, -87 lines 0 comments Download
D chromecast/media/cma/backend/alsa/filter_group.cc View 1 chunk +0 lines, -119 lines 0 comments Download
M chromecast/media/cma/backend/alsa/media_pipeline_backend_alsa.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chromecast/media/cma/backend/alsa/media_pipeline_backend_alsa.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa.h View 5 chunks +14 lines, -16 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc View 12 chunks +99 lines, -105 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input.h View 2 chunks +1 line, -3 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input_impl.h View 5 chunks +0 lines, -9 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_input_impl.cc View 7 chunks +5 lines, -18 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa_unittest.cc View 5 chunks +2 lines, -55 lines 0 comments Download
M chromecast/media/cma/backend/media_pipeline_backend_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/media/cma/pipeline/load_type.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/media/cma/pipeline/media_pipeline_impl.cc View 2 chunks +5 lines, -14 lines 0 comments Download
M chromecast/media/service/cast_renderer.cc View 3 chunks +1 line, -16 lines 0 comments Download
M chromecast/public/media/media_pipeline_device_params.h View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
bshaya
Created Revert of [Chromecast] Process streams with different post-processing.
3 years, 9 months ago (2017-02-28 07:50:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722673004/1
3 years, 9 months ago (2017-02-28 07:50:46 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-02-28 07:50:48 UTC) #5
halliwell
On 2017/02/28 07:50:48, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 9 months ago (2017-02-28 14:11:53 UTC) #6
wzhong
lgtm
3 years, 9 months ago (2017-02-28 15:25:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722673004/1
3 years, 9 months ago (2017-02-28 16:23:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/65dc9e8742f0e87c511806dcc3823cc4c4be8ad4
3 years, 9 months ago (2017-02-28 16:24:43 UTC) #12
bshaya
3 years, 9 months ago (2017-02-28 16:58:10 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2722833003/ by bshaya@google.com.

The reason for reverting is: Fix breakage.

Powered by Google App Engine
This is Rietveld 408576698