Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2722653002: Convert editing/pasteboard/paste-text-at-tabspan-002.html with assert_selection (Closed)

Created:
3 years, 9 months ago by Xiaocheng
Modified:
3 years, 9 months ago
Reviewers:
tkent, yoichio, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/pasteboard/paste-text-at-tabspan-002.html with assert_selection This patch converts the above mentioned layout test with assert_selection to promote the use of w3c testharness and improve code health. This is also preparation for https://codereview.chromium.org/2720063002 BUG=679977 Review-Url: https://codereview.chromium.org/2722653002 Cr-Commit-Position: refs/heads/master@{#453448} Committed: https://chromium.googlesource.com/chromium/src/+/ee8a846f90aa77676d567be0b3daeb03704ae83d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -53 lines) Patch
M third_party/WebKit/LayoutTests/editing/pasteboard/paste-text-at-tabspan-002.html View 1 chunk +30 lines, -26 lines 1 comment Download
D third_party/WebKit/LayoutTests/editing/pasteboard/paste-text-at-tabspan-002-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Xiaocheng
PTAL.
3 years, 9 months ago (2017-02-28 00:06:56 UTC) #7
Xiaocheng
3 years, 9 months ago (2017-02-28 00:08:11 UTC) #9
yosin_UTC9
lgtm https://codereview.chromium.org/2722653002/diff/1/third_party/WebKit/LayoutTests/editing/pasteboard/paste-text-at-tabspan-002.html File third_party/WebKit/LayoutTests/editing/pasteboard/paste-text-at-tabspan-002.html (right): https://codereview.chromium.org/2722653002/diff/1/third_party/WebKit/LayoutTests/editing/pasteboard/paste-text-at-tabspan-002.html#newcode15 third_party/WebKit/LayoutTests/editing/pasteboard/paste-text-at-tabspan-002.html:15: '<span class="Apple-tab-span" style="white-space:pre"> | </span>', FYI: We're working ...
3 years, 9 months ago (2017-02-28 01:53:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722653002/1
3 years, 9 months ago (2017-02-28 01:54:26 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ee8a846f90aa77676d567be0b3daeb03704ae83d
3 years, 9 months ago (2017-02-28 02:00:49 UTC) #15
Xiaocheng
3 years, 9 months ago (2017-02-28 02:01:32 UTC) #16
Message was sent while issue was closed.
On 2017/02/28 at 01:53:55, yosin wrote:
> lgtm
> 
>
https://codereview.chromium.org/2722653002/diff/1/third_party/WebKit/LayoutTe...
> File
third_party/WebKit/LayoutTests/editing/pasteboard/paste-text-at-tabspan-002.html
(right):
> 
>
https://codereview.chromium.org/2722653002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/editing/pasteboard/paste-text-at-tabspan-002.html:15:
'<span class="Apple-tab-span" style="white-space:pre">	|		</span>',
> FYI: We're working to get rid of "Apple-tab-span"[1].
> 
> [1] http://crbug.com/383677 Deprecate Blink specific CSS class name for
editing

Yeah, I'm aware of that.

Thanks anyway.

Powered by Google App Engine
This is Rietveld 408576698