Make Editor::changeSelectionAfterCommand take SelectionInDOMTree

Make Editor::changeSelectionAfterCommand take SelectionInDOMTree

Now that changing selection no longer requires layout, there is no
need to pass a canonicalized selection to changeSelectionAfterCommand
at the end of an editing command.

Hence, this patch makes the above mentioned function take a
SelectionInDOMTree instead.

BUG=657237
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2720063002
Cr-Commit-Position: refs/heads/master@{#453795}
Committed: https://chromium.googlesource.com/chromium/src/+/9891ad7aa94964b5cee2cd7c73ee02fdd173fbbe

[Xiaocheng, 2017-02-27 20:10:13]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 20:10:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-02-27 20:11:12]

Description was changed from

==========
Make Editor::changeSelectionAfterCommand take SelectionInDOMTree

BUG=657237
==========

to

==========
Make Editor::changeSelectionAfterCommand take SelectionInDOMTree

editing/deleting/delete-block-merge-contents-010.html [ Failure ]
editing/inserting/insert-text-at-tabspan-002.html [ Failure ]
editing/pasteboard/paste-text-at-tabspan-002.html [ Failure ]
editing/pasteboard/paste-xml.xhtml [ Failure ]
editing/pasteboard/pasting-object.html [ Failure ]
editing/style/style-3690704-fix.html [ Failure ]
editing/style/style-boundary-005.html [ Failure ]

BUG=657237
==========

[commit-bot: I haz the power, 2017-02-27 21:43:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 21:43:53]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xiaocheng, 2017-02-28 21:08:48]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 21:09:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-02-28 22:03:37]

Description was changed from

==========
Make Editor::changeSelectionAfterCommand take SelectionInDOMTree

editing/deleting/delete-block-merge-contents-010.html [ Failure ]
editing/inserting/insert-text-at-tabspan-002.html [ Failure ]
editing/pasteboard/paste-text-at-tabspan-002.html [ Failure ]
editing/pasteboard/paste-xml.xhtml [ Failure ]
editing/pasteboard/pasting-object.html [ Failure ]
editing/style/style-3690704-fix.html [ Failure ]
editing/style/style-boundary-005.html [ Failure ]

BUG=657237
==========

to

==========
Make Editor::changeSelectionAfterCommand take SelectionInDOMTree

Now that changing selection no longer requires layout, there is no
need to pass a canonicalized selection to changeSelectionAfterCommand
at the end of an editing command.

Hence, this patch makes the above mentioned function take a
SelectionInDOMTree instead.

BUG=657237
TEST=n/a; no behavior change
==========

[Xiaocheng, 2017-02-28 22:03:38]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-02-28 22:03:52]

PTAL.

[commit-bot: I haz the power, 2017-02-28 23:00:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 23:00:06]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-03-01 01:20:39]

https://codereview.chromium.org/2720063002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/2720063002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/Editor.cpp:869: static VisibleSelection
correctedVisibleSelection(
It seems you need to rebase. Patch[1] did this change.

[1] http://crrev.co/2709973005: Get rid of useless function
VisibleSelection::updateIfNeeded()

[Xiaocheng, 2017-03-01 01:41:23]

https://codereview.chromium.org/2720063002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/2720063002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/Editor.cpp:869: static VisibleSelection
correctedVisibleSelection(
On 2017/03/01 at 01:20:39, yosin_UTC9 wrote:
> It seems you need to rebase. Patch[1] did this change.
> 
> [1] http://crrev.co/2709973005: Get rid of useless function
VisibleSelection::updateIfNeeded()

No need to rebase.

This patch removes this function before Editor::appliedEditing so that it can
also be called there.

[yosin_UTC9, 2017-03-01 01:44:01]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-03-01 01:44:01]

lgtm

https://codereview.chromium.org/2720063002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/2720063002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/Editor.cpp:869: static VisibleSelection
correctedVisibleSelection(
On 2017/03/01 at 01:41:23, Xiaocheng wrote:
> On 2017/03/01 at 01:20:39, yosin_UTC9 wrote:
> > It seems you need to rebase. Patch[1] did this change.
> > 
> > [1] http://crrev.co/2709973005: Get rid of useless function
VisibleSelection::updateIfNeeded()
> 
> No need to rebase.
> 
> This patch removes this function before Editor::appliedEditing so that it can
also be called there.

Oops. I see.

[commit-bot: I haz the power, 2017-03-01 01:44:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 01:44:22]

This CL has an open dependency (Issue 2720123002 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Xiaocheng, 2017-03-01 01:46:17]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2017-03-01 01:46:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 02:46:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488332777409280,
"parent_rev": "f97311b4375b05e920543271240dd68f06057e54", "commit_rev":
"9891ad7aa94964b5cee2cd7c73ee02fdd173fbbe"}

[commit-bot: I haz the power, 2017-03-01 02:46:47]

Description was changed from

==========
Make Editor::changeSelectionAfterCommand take SelectionInDOMTree

Now that changing selection no longer requires layout, there is no
need to pass a canonicalized selection to changeSelectionAfterCommand
at the end of an editing command.

Hence, this patch makes the above mentioned function take a
SelectionInDOMTree instead.

BUG=657237
TEST=n/a; no behavior change
==========

to

==========
Make Editor::changeSelectionAfterCommand take SelectionInDOMTree

Now that changing selection no longer requires layout, there is no
need to pass a canonicalized selection to changeSelectionAfterCommand
at the end of an editing command.

Hence, this patch makes the above mentioned function take a
SelectionInDOMTree instead.

BUG=657237
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2720063002
Cr-Commit-Position: refs/heads/master@{#453795}
Committed:
https://chromium.googlesource.com/chromium/src/+/9891ad7aa94964b5cee2cd7c73ee...
==========

[commit-bot: I haz the power, 2017-03-01 02:46:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9891ad7aa94964b5cee2cd7c73ee...