Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2722643002: Add back DCHECK for pointer type in PointerEventFactory (Closed)

Created:
3 years, 9 months ago by Navid Zolghadr
Modified:
3 years, 9 months ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add back DCHECK for pointer type in PointerEventFactory This DCHECK was originally commented here https://codereview.chromium.org/2659523004/ and after the fix landed here https://codereview.chromium.org/2688793003/ but it got mistakenly reverted due to crbug.com/694742 which had nothing to do with this DCHECK. So this re-re-enables this pointertype DCHECK for coalesced pointer events. BUG=684292 Review-Url: https://codereview.chromium.org/2722643002 Cr-Commit-Position: refs/heads/master@{#453603} Committed: https://chromium.googlesource.com/chromium/src/+/ef2a8e07616635ec90e8b30a95fb8a43a7f0ec9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/core/events/PointerEventFactory.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Navid Zolghadr
3 years, 9 months ago (2017-02-27 20:43:36 UTC) #4
bokan
lgtm
3 years, 9 months ago (2017-02-27 22:48:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722643002/1
3 years, 9 months ago (2017-02-28 15:17:08 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 15:21:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ef2a8e07616635ec90e8b30a95fb...

Powered by Google App Engine
This is Rietveld 408576698