Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2722633003: Remove Port.buildbot_archives_baselines. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
jeffcarp, ojan
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Port.buildbot_archives_baselines. Reason: This method returns true for all ports, and I think that it probably should for all supported ports in the future. BUG=677561 Review-Url: https://codereview.chromium.org/2722633003 Cr-Commit-Position: refs/heads/master@{#454733} Committed: https://chromium.googlesource.com/chromium/src/+/079bb00b9cf3691100e5ed8f987d9b4207c71da0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
qyearsley
Like https://crrev.com/2721603003, this CL would remove a method that seems unnecessary, but I'm not sure ...
3 years, 9 months ago (2017-02-27 21:14:06 UTC) #6
qyearsley
Adding Jeff as reviewer :-)
3 years, 9 months ago (2017-03-02 20:07:43 UTC) #8
jeffcarp
lgtm
3 years, 9 months ago (2017-03-03 23:35:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722633003/1
3 years, 9 months ago (2017-03-03 23:42:22 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-04 00:59:05 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/079bb00b9cf3691100e5ed8f987d...

Powered by Google App Engine
This is Rietveld 408576698