Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 2722633003: Remove Port.buildbot_archives_baselines. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2010 Google Inc. All rights reserved. 1 # Copyright (c) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 self.builder_option, 145 self.builder_option,
146 self.test_option, 146 self.test_option,
147 ]) 147 ])
148 148
149 @memoized 149 @memoized
150 def _immediate_predecessors_in_fallback(self, path_to_rebaseline): 150 def _immediate_predecessors_in_fallback(self, path_to_rebaseline):
151 port_names = self._tool.port_factory.all_port_names() 151 port_names = self._tool.port_factory.all_port_names()
152 immediate_predecessors = [] 152 immediate_predecessors = []
153 for port_name in port_names: 153 for port_name in port_names:
154 port = self._tool.port_factory.get(port_name) 154 port = self._tool.port_factory.get(port_name)
155 if not port.buildbot_archives_baselines():
156 continue
157 baseline_search_path = port.baseline_search_path() 155 baseline_search_path = port.baseline_search_path()
158 try: 156 try:
159 index = baseline_search_path.index(path_to_rebaseline) 157 index = baseline_search_path.index(path_to_rebaseline)
160 if index: 158 if index:
161 immediate_predecessors.append(self._tool.filesystem.basename (baseline_search_path[index - 1])) 159 immediate_predecessors.append(self._tool.filesystem.basename (baseline_search_path[index - 1]))
162 except ValueError: 160 except ValueError:
163 # baseline_search_path.index() throws a ValueError if the item i sn't in the list. 161 # baseline_search_path.index() throws a ValueError if the item i sn't in the list.
164 pass 162 pass
165 return immediate_predecessors 163 return immediate_predecessors
166 164
(...skipping 550 matching lines...) Expand 10 before | Expand all | Expand 10 after
717 for test in args: 715 for test in args:
718 if test not in test_prefix_list: 716 if test not in test_prefix_list:
719 test_prefix_list[test] = {} 717 test_prefix_list[test] = {}
720 build = Build(builder) 718 build = Build(builder)
721 test_prefix_list[test][build] = suffixes_to_update 719 test_prefix_list[test][build] = suffixes_to_update
722 720
723 if options.verbose: 721 if options.verbose:
724 _log.debug("rebaseline-json: " + str(test_prefix_list)) 722 _log.debug("rebaseline-json: " + str(test_prefix_list))
725 723
726 self.rebaseline(options, test_prefix_list) 724 self.rebaseline(options, test_prefix_list)
OLDNEW
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698