third_party/WebKit/Source/core/layout/LayoutFullScreen.h - Issue 2722613003: [css-grid] "normal" alignment is "start" for replaced elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFullScreen.h

Issue 2722613003: [css-grid] "normal" alignment is "start" for replaced elements (Closed)

Patch Set: Applied suggested changes Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutFullScreen.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutFullScreen.h b/third_party/WebKit/Source/core/layout/LayoutFullScreen.h

index 1851f2fe0798989ab25c99299b9e460bce49dca2..db7d3e6e467157ef4cd8f3907312df3c964392cf 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFullScreen.h

+++ b/third_party/WebKit/Source/core/layout/LayoutFullScreen.h

@@ -67,7 +67,9 @@ class CORE_EXPORT LayoutFullScreen final : public LayoutFlexibleBox {

protected:

LayoutBlockFlow* m_placeholder;

- ItemPosition selfAlignmentNormalBehavior() const override {

+ ItemPosition selfAlignmentNormalBehavior(

+ const LayoutBox* child = nullptr) const override {

+ DCHECK(!child);

return ItemPositionCenter;

}

};