Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.h

Issue 2722613003: [css-grid] "normal" alignment is "start" for replaced elements (Closed)
Patch Set: Applied suggested changes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutGrid.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.h b/third_party/WebKit/Source/core/layout/LayoutGrid.h
index ed2b80926039a6c6ba765fe64a7d8a47251c575e..84d80b814f27536fced40af0d2dd8768944ecc89 100644
--- a/third_party/WebKit/Source/core/layout/LayoutGrid.h
+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.h
@@ -96,6 +96,13 @@ class LayoutGrid final : public LayoutBlock {
bool cachedHasDefiniteLogicalHeight() const;
bool isOrthogonalChild(const LayoutBox&) const;
+ protected:
+ ItemPosition selfAlignmentNormalBehavior(
+ const LayoutBox* child = nullptr) const override {
+ DCHECK(child);
+ return child->isLayoutReplaced() ? ItemPositionStart : ItemPositionStretch;
+ }
+
private:
bool isOfType(LayoutObjectType type) const override {
return type == LayoutObjectLayoutGrid || LayoutBlock::isOfType(type);
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFullScreen.h ('k') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698